Page 20 of 32

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 6:52 am
by lacilaci
B.Y.O.B. wrote: Tue Feb 05, 2019 8:44 pm
lacilaci wrote: Tue Feb 05, 2019 8:35 pm If you can solve this, you might also get ready to implement albedo and avg normal pass for bidir.
Dade already did this.
In blender the aov Avg. Shading Normal is grayed out, but it can be checked and works. So that what confused me.

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 10:48 am
by B.Y.O.B.
lacilaci wrote: Wed Feb 06, 2019 5:40 am @B.Y.O.B. - Denoised pass doesn't have alpha in blender. My transparent background is black in the denoised pass, can be something done about that?
Maybe in the future, for now I would recommend to enable the Alpha AOV and use the compositor to make the denoised output transparent.
lacilaci wrote: Wed Feb 06, 2019 6:52 am In blender the aov Avg. Shading Normal is grayed out, but it can be checked and works. So that what confused me.
Thanks for the reminder, I updated the UI.

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 11:20 am
by Dade
It works !

The problem was in the implementation of the "NONE" pixel filter, I "simplified" the way it works and now Oidn recognize the noise and works with BIDir (no problem with Metropolis too):

bidir.jpg

Yuppie !

@B.Y.O.B.: you should always force the "film.filter.type = NONE" with BIDir+Oidn in BlendLuxCore.

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 11:25 am
by lacilaci
Dade wrote: Wed Feb 06, 2019 11:20 am It works !

The problem was in the implementation of the "NONE" pixel filter, I "simplified" the way it works and now Oidn recognize the noise and works with BIDir (no problem with Metropolis too):


bidir.jpg


Yuppie !

@B.Y.O.B.: you should always force the "film.filter.type = NONE" with BIDir+Oidn in BlendLuxCore.
Oh boy, this is amazing... is there a build?

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 11:27 am
by Dade
lacilaci wrote: Wed Feb 06, 2019 11:25 am Oh boy, this is amazing... is there a build?
It is cooking: https://dev.azure.com/LuxCoreRender/Lux ... uildId=200

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 11:45 am
by FarbigeWelt
Dade wrote: Wed Feb 06, 2019 11:20 am It works !
Congratulations, Dade!

And sure for all others involved in this exceptional performance.



(I am close to be speaklessly overwhelmd.)

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 11:53 am
by lacilaci
Dade wrote: Wed Feb 06, 2019 11:27 am
lacilaci wrote: Wed Feb 06, 2019 11:25 am Oh boy, this is amazing... is there a build?
It is cooking: https://dev.azure.com/LuxCoreRender/Lux ... uildId=200
BTW, did you fix the unknown imagepipeline error for linux build? Windows works, and B.Y.O.B. own build worked yesterday aswell but azure linux didn't.

EDIT: To answer my own question, daily builds of linux no longer throw the error aobut uknown image pipeline when using oidn.

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 12:13 pm
by B.Y.O.B.
Awesome!
Dade wrote: Wed Feb 06, 2019 11:20 am @B.Y.O.B.: you should always force the "film.filter.type = NONE" with BIDir+Oidn in BlendLuxCore.
Done.

Here's a 64 sample render with Bidir + OIDN:

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 12:17 pm
by epilectrolytics
FarbigeWelt wrote: Wed Feb 06, 2019 11:45 am (I am close to be speaklessly overwhelmd.)
Possibly a divine intervention by JAHEW or SIHVA helped to make OIDN work :lol:

Re: OpenImageDenoise

Posted: Wed Feb 06, 2019 12:19 pm
by lacilaci
This is incredible... I might actually give bidir a try in some cases!