Reduce the number of OpenCL kernel compilations

[kintuX]

This was a Windows-only problem and should now be fixed.

Indeed.
Build succeeded.
Thank you.

[Dade]

Changing AOVs used doesn't require OpenCL compilation anymore (removed PARAM_FILM_CHANNELS_*).

[kintuX]

Latest commits again break the windows cmake build:
(ending of console output)

Code: Select all

...
...
...
  c:\luxcorerender\windowscompile\build_cmake\luxcore\src\slg\sampleresult_types.cl(39): error C4430: missing ty
       pe specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\luxcorerender\LuxCo
       re\src\slg\rendersession.cpp) [C:\luxcorerender\WindowsCompile\Build_CMake\LuxCore\src\slg\slg-core.vcxproj]
         c:\luxcorerender\windowscompile\build_cmake\luxcore\src\slg\sampleresult_types.cl(41): error C3646: 'objectID'
       : unknown override specifier (compiling source file C:\luxcorerender\LuxCore\src\slg\rendersession.cpp) [C:\luxc
       orerender\WindowsCompile\Build_CMake\LuxCore\src\slg\slg-core.vcxproj]
         c:\luxcorerender\windowscompile\build_cmake\luxcore\src\slg\sampleresult_types.cl(41): error C4430: missing ty
       pe specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\luxcorerender\LuxCo
       re\src\slg\rendersession.cpp) [C:\luxcorerender\WindowsCompile\Build_CMake\LuxCore\src\slg\slg-core.vcxproj]

    0 Warning(s)
    714 Error(s)

Time Elapsed 00:00:38.26
--- FATAL ERROR RUNNING CMAKE ---

[lacilaci]

how many more are there? Asking so that I can put correct number of entries on trello.. right now this task is always 95% done

[Dade]

Latest commits again break the windows cmake build:
(ending of console output)

Code: Select all

...
...
...
  c:\luxcorerender\windowscompile\build_cmake\luxcore\src\slg\sampleresult_types.cl(39): error C4430: missing ty
       pe specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\luxcorerender\LuxCo
       re\src\slg\rendersession.cpp) [C:\luxcorerender\WindowsCompile\Build_CMake\LuxCore\src\slg\slg-core.vcxproj]
         c:\luxcorerender\windowscompile\build_cmake\luxcore\src\slg\sampleresult_types.cl(41): error C3646: 'objectID'
       : unknown override specifier (compiling source file C:\luxcorerender\LuxCore\src\slg\rendersession.cpp) [C:\luxc
       orerender\WindowsCompile\Build_CMake\LuxCore\src\slg\slg-core.vcxproj]
         c:\luxcorerender\windowscompile\build_cmake\luxcore\src\slg\sampleresult_types.cl(41): error C4430: missing ty
       pe specifier - int assumed. Note: C++ does not support default-int (compiling source file C:\luxcorerender\LuxCo
       re\src\slg\rendersession.cpp) [C:\luxcorerender\WindowsCompile\Build_CMake\LuxCore\src\slg\slg-core.vcxproj]

    0 Warning(s)
    714 Error(s)

Time Elapsed 00:00:38.26
--- FATAL ERROR RUNNING CMAKE ---

I should have fixed this probelm.

[Dade]

Adding/Removing a new light source type doesn't require OpenCL compilation anymore (removed PARAM_HAS_*LIGHT).

[kintuX]

I should have fixed this probelm.

Confirming. It now builds w/o problems.

[Dade]

The work on this topic for v2.3 is done. Any further development will continue on a branch for v2.4.

Materials/Textures aside (v2.4 stuff), there are now only the following conditional compilations:

- render engine type: PATHOCL, TILEPATHOCL and RTPATHOCL
- epsilon min. and epsilon max. values;

So, assuming you are using the default epsilon min./max. and Materials/Textures aside, there are now only 3 types of kernel used.

[Sharlybg]

Thanks for the hard work Dade !

[Dade]

This task is concluded with viewtopic.php?f=5&t=1812