Page 4 of 6

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue Jun 22, 2021 11:31 pm
by Dade
Can you post a cube scene with that material ?

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 9:38 am
by juangea
I sent you the file with the asset and materials / textures in a PM :)

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 10:50 am
by kintuX
Is it correct to totally disregard SHADING NORMAL pass & denoises anyway?

Eg.
Gold w Bump (Normal map), rendered to 5k samples (Halt Noise Treshold @ 6).

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 10:57 am
by Dade
In latest sources and with OIDN v1.4, I'm pre-filtering only the Albedo pass but looking at the images I'm starting to think that it may be worth pre-filtering the normal pass too. I will do some test.

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 11:19 am
by juangea
I think that looking at the results, the best course of action would be to give the user all the options, so there is a default behavior, but the user can go and decide what happens with each pass and how OIDN should treat them.

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 11:32 am
by B.Y.O.B.
kintuX wrote: Wed Jun 23, 2021 10:50 am Is it correct to totally disregard SHADING NORMAL pass & denoises anyway?
OIDN uses the Avg. Shading Normal pass (Avg. = Average).
In the Blender addon, it is enabled automatically behind the scenes when the denoiser is used.

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 11:42 am
by kintuX
B.Y.O.B. wrote: Wed Jun 23, 2021 11:32 am
kintuX wrote: Wed Jun 23, 2021 10:50 am Is it correct to totally disregard SHADING NORMAL pass & denoises anyway?
OIDN uses the Avg. Shading Normal pass (Avg. = Average).
In the Blender addon, it is enabled automatically behind the scenes when the denoiser is used.
Oh, so that's why details are gone. (Yes, avg. nrml pass was smooth)
Is there a simple way to switch it?

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 12:50 pm
by B.Y.O.B.
Switch what?

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 1:23 pm
by kintuX
B.Y.O.B. wrote: Wed Jun 23, 2021 12:50 pmSwitch what?
For OIDN to use "Shading normal" instead of "Avg." pass.

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Wed Jun 23, 2021 2:04 pm
by juangea
One important thing regarding OIDN 1.4.1:
chrome_FNaHVXsBJW.png