PhotonGI cache

Discussion related to the LuxCore functionality, implementations and API.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: PhotonGI cache

Post by B.Y.O.B. »

I have exposed the maxsize property again.
User avatar
Sharlybg
Donor
Donor
Posts: 3104
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: PhotonGI cache

Post by Sharlybg »

Ok a simple recap of the situation and upcoming feature and Speed.

PhotonGI + OIDN + 7nm(GPU+CPU) + Topaz Ai Gigapixel = :shock:

Never mind one day that Luxcore = Skynet :lol:
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA
User avatar
Dade
Developer
Developer
Posts: 5675
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: PhotonGI cache

Post by Dade »

lacilaci wrote: Wed Feb 06, 2019 1:13 pm
Dade wrote: Wed Feb 06, 2019 1:00 pm Post a (simple) test scene, pls.
This actually is a simple testscene....
Just use the debug option to directly visualize the direct cache and you will understand a lot (this is the second scene camera, the first one is even worse):

direct.jpg

This seems the result of a BlendLuxCore bug, it doesn't set the direct cache size (and the default value is very small). It should be set to something like: 2 * <indirect cache size> / <max. photon path depth>

The correct output:

direct-fix.jpg

Not say that this fix everything but having a direct light cache with something inside helps :D
Support LuxCoreRender project with salts and bounties
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: PhotonGI cache

Post by B.Y.O.B. »

Why the direct cache? Isn't it supposed to be disabled?
Dade wrote: Wed Feb 06, 2019 4:58 pm It should be set to something like: 2 * <indirect cache size> / <max. photon path depth>
I tried to do this but the direct cache debug output is completely black on all surfaces.
When I enable it with "path.photongi.direct.enabled = 1" I can see the same output as in your post, but when I switch debug mode off, the render is full of direct light cache splotches. I'm confused.
User avatar
Dade
Developer
Developer
Posts: 5675
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: PhotonGI cache

Post by Dade »

B.Y.O.B. wrote: Wed Feb 06, 2019 5:28 pm Why the direct cache? Isn't it supposed to be disabled?
Dade wrote: Wed Feb 06, 2019 4:58 pm It should be set to something like: 2 * <indirect cache size> / <max. photon path depth>
I tried to do this but the direct cache debug output is completely black on all surfaces.
When I enable it with "path.photongi.direct.enabled = 1" I can see the same output as in your post, but when I switch debug mode off, the render is full of direct light cache splotches. I'm confused.
Yes, for the debug, and only for the debug, you have to use "path.photongi.direct.enabled = 1":

- debug on enable the related cache => "path.photongi.direct/indirect/caustic.enabled = 1"

- debug off, keep direct cache disabled => "path.photongi.direct.enabled = 0"
Support LuxCoreRender project with salts and bounties
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: PhotonGI cache

Post by B.Y.O.B. »

User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: PhotonGI cache

Post by lacilaci »

Trying the latest builds... I cannot do anything to avoid those corner "leaks"

Btw, will the cache work with bidir too?
User avatar
Dade
Developer
Developer
Posts: 5675
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: PhotonGI cache

Post by Dade »

lacilaci wrote: Thu Feb 07, 2019 12:12 pm Btw, will the cache work with bidir too?
Nope, it not applicable in that context (BiDir traces a light path for every sample, if you cache the light path ... it just becomes path tracing + cache).
Support LuxCoreRender project with salts and bounties
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: PhotonGI cache

Post by lacilaci »

Dade wrote: Thu Feb 07, 2019 5:32 pm
lacilaci wrote: Thu Feb 07, 2019 12:12 pm Btw, will the cache work with bidir too?
Nope, it not applicable in that context (BiDir traces a light path for every sample, if you cache the light path ... it just becomes path tracing + cache).
then maybe some pathguiding for bidir?
User avatar
Dade
Developer
Developer
Posts: 5675
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: PhotonGI cache

Post by Dade »

lacilaci wrote: Thu Feb 07, 2019 5:42 pm
Dade wrote: Thu Feb 07, 2019 5:32 pm
lacilaci wrote: Thu Feb 07, 2019 12:12 pm Btw, will the cache work with bidir too?
Nope, it not applicable in that context (BiDir traces a light path for every sample, if you cache the light path ... it just becomes path tracing + cache).
then maybe some pathguiding for bidir?
Yes, that would be a possibility.
Support LuxCoreRender project with salts and bounties
Post Reply