Light group support for PhotonGI?

[juangea]

I was referring to the clamping value in general, having a clamping value per light group it's even better

[Dade]

In the hall bench scene, the VRAM usage is:
- without cache: 1029 MiB
- with cache: 1031 MiB

Are you sure ? I mean, if I can ignore the "additional memory problem" I can easily add the support for light groups (storing 8 x 3 floats values instead of 3 float, max. light group count x RGB instead of 1 x RGB).

The question is: the memory usage will jump from 2MB to 16MB (and no one care) or it will jump from 100MB to 800MB and people will start to load their guns

[Sharlybg]

The question is: the memory usage will jump from 2MB to 16MB (and no one care) or it will jump from 100MB to 800MB and people will start to load their guns

We just need a warning Message on it. Being a special features it is acceptable to have such sacrifice to do. multiple render in one this is awesome.

[Dade]

The question is: the memory usage will jump from 2MB to 16MB (and no one care) or it will jump from 100MB to 800MB and people will start to load their guns

We just need a warning Message on it. Being a special features it is acceptable to have such sacrifice to do. multiple render in one this is awesome.

No, it is not optional, even if you use a single light group, it will use 16MB instead of 2MB (i.e. no problem) and 800MB instead of 100MB (i.e. big problem).

[Sharlybg]

No, it is not optional, even if you use a single light group, it will use 16MB instead of 2MB (i.e. no problem) and 800MB instead of 100MB (i.e. big problem).

understood (This is Crazy )

So maybe boosted Path/Bidir will make the trick

[B.Y.O.B.]

In the hall bench scene, the VRAM usage is:
- without cache: 1029 MiB
- with cache: 1031 MiB

Are you sure ? I mean, if I can ignore the "additional memory problem" I can easily add the support for light groups (storing 8 x 3 floats values instead of 3 float, max. light group count x RGB instead of 1 x RGB).

The question is: the memory usage will jump from 2MB to 16MB (and no one care) or it will jump from 100MB to 800MB and people will start to load their guns

Some tests, VRAM usage of PhotonGI indirect light cache (no caustics cache), as reported by LuxCore:

Danish Mood:
- without cache: 577 MiB
- with cache: 580 MiB
Diff 3 MiB

LuxCore 2.1 Benchmark:
- without cache: 479 MiB
- with cache: 486 MiB
Diff: 7 MiB

LuxBall scene from https://github.com/LuxCoreRender/LuxCor ... s/tag/v2.3:
- without cache: 269 MiB
- with cache: 296 MiB
Diff: 27 MiB

DLSC testscene:
- without cache: 374 MiB
- with cache: 376 MiB
Diff: 2 MiB

If these numbers look fishy to you, maybe LuxCore is not counting all VRAM usage of PhotonGI? However, the VRAM usage I see in the task manager looking mostly the same)

No, it is not optional, even if you use a single light group, it will use 16MB instead of 2MB (i.e. no problem) and 800MB instead of 100MB (i.e. big problem).

The memory can't be allocated only on demand?

[Dade]

If these numbers look fishy to you, maybe LuxCore is not counting all VRAM usage of PhotonGI?

No, if you are reading the numbers from the log, they are correct as far as I know.

The memory can't be allocated only on demand?

It is but is more complex (mostly in OpenCL).

[Dade]

I added the support for light groups to PhotonGI (both indirect and caustic cache)

[Sharlybg]

I added the support for light groups to PhotonGI (both indirect and caustic cache)

That was fast. We still need blendluxcore add to test i guess.

[Dade]

I added the support for light groups to PhotonGI (both indirect and caustic cache)

That was fast. We still need blendluxcore add to test i guess.

Nope, it should work out of the box.