OpenImageDenoise

Discussion related to the LuxCore functionality, implementations and API.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: OpenImageDenoise

Post by B.Y.O.B. »

Dade wrote: Mon Feb 04, 2019 3:59 pm It may be a side effect of some internal Oidn behavior: Alpistinho is initializing the Oidn device and filter at the plugin allocation, we could do that for every apply() however it may be slower so I tend to agree with Alpistinho's decision.
If you are talking about the stuff in the constructor, this takes 0.2 ms on my notebook CPU:

Code: Select all

OIDN constructor took 0.000236034 seconds
So I would just move it to Apply.
User avatar
Dade
Developer
Developer
Posts: 5675
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: OpenImageDenoise

Post by Dade »

B.Y.O.B. wrote: Mon Feb 04, 2019 4:35 pm So I would just move it to Apply.
Done.
Support LuxCoreRender project with salts and bounties
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: OpenImageDenoise

Post by B.Y.O.B. »

Thanks, the memory hogging is gone.
User avatar
FarbigeWelt
Donor
Donor
Posts: 1074
Joined: Sun Jul 01, 2018 12:07 pm
Location: Switzerland
Contact:

Re: OpenImageDenoise

Post by FarbigeWelt »

Dade wrote: Mon Feb 04, 2019 4:28 pm Second try, hopeful fixed now:

COMP-3x3-fixed.png
Does anybody else observe the lack of depth of denoised images in the first two rows compared to the noisy one in the same line. Is this an illusion of mine, this good visible distance between the left top edge of the plate and the wall in the background?

Beside that, it’s amazing how good oidn works. And even more, how fast and far you got!
Light and Word designing Creator - aka quantenkristall || #luxcorerender
MacBook Air with M1
User avatar
Dade
Developer
Developer
Posts: 5675
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: OpenImageDenoise

Post by Dade »

FarbigeWelt wrote: Mon Feb 04, 2019 5:07 pm
Dade wrote: Mon Feb 04, 2019 4:28 pm Second try, hopeful fixed now:

COMP-3x3-fixed.png
Does anybody else observe the lack of depth of denoised images in the first two rows compared to the noisy one in the same line. Is this an illusion of mine, this good visible distance between the left top edge of the plate and the wall in the background?

Beside that, it’s amazing how good oidn works. And even more, how fast and far you got!
Left side of the image is brighter the the right side. When right side is attached to the left side of another rendering it may lead to perceive, a not existing, difference ... but it is really hard to judge as all human perception related things.
Support LuxCoreRender project with salts and bounties
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci »

FarbigeWelt wrote: Mon Feb 04, 2019 5:07 pm
Dade wrote: Mon Feb 04, 2019 4:28 pm Second try, hopeful fixed now:

COMP-3x3-fixed.png
Does anybody else observe the lack of depth of denoised images in the first two rows compared to the noisy one in the same line. Is this an illusion of mine, this good visible distance between the left top edge of the plate and the wall in the background?

Beside that, it’s amazing how good oidn works. And even more, how fast and far you got!
The difference between noisy and denoised image is much much bigger to perception than people think.
Noise is incredibly distracting and I couldn't count how many times I thought everything is fine and then render finals and it's shit without details. Denoiser/or really clean render really shows how good or not the scene etc, is, while noise leaves lot for imagination.
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci »

Ok, so on twitter Attila Afra said that bidir without metropolis should be ok, I can't test now but is this possibe?

Check out @attila_afra’s Tweet: https://twitter.com/attila_afra/status/ ... 45859?s=09
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: OpenImageDenoise

Post by B.Y.O.B. »

I tested Bidir with Random sampler and the denoiser changed nothing.
epilectrolytics
Donor
Donor
Posts: 814
Joined: Thu Oct 04, 2018 6:06 am

Re: OpenImageDenoise

Post by epilectrolytics »

B.Y.O.B. wrote: Mon Feb 04, 2019 7:09 pm I tested Bidir with Random sampler and the denoiser changed nothing.
Maybe also test Path metro?
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci »

epilectrolytics wrote: Mon Feb 04, 2019 7:15 pm
B.Y.O.B. wrote: Mon Feb 04, 2019 7:09 pm I tested Bidir with Random sampler and the denoiser changed nothing.
Maybe also test Path metro?
path+metro works fine with nvidia. I think it would with intel too. Will test in the morning
Post Reply