OpenImageDenoise

Discussion related to the LuxCore functionality, implementations and API.
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci »

B.Y.O.B. wrote: Tue Feb 05, 2019 8:44 pm
lacilaci wrote: Tue Feb 05, 2019 8:35 pm If you can solve this, you might also get ready to implement albedo and avg normal pass for bidir.
Dade already did this.
In blender the aov Avg. Shading Normal is grayed out, but it can be checked and works. So that what confused me.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: OpenImageDenoise

Post by B.Y.O.B. »

lacilaci wrote: Wed Feb 06, 2019 5:40 am @B.Y.O.B. - Denoised pass doesn't have alpha in blender. My transparent background is black in the denoised pass, can be something done about that?
Maybe in the future, for now I would recommend to enable the Alpha AOV and use the compositor to make the denoised output transparent.
lacilaci wrote: Wed Feb 06, 2019 6:52 am In blender the aov Avg. Shading Normal is grayed out, but it can be checked and works. So that what confused me.
Thanks for the reminder, I updated the UI.
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: OpenImageDenoise

Post by Dade »

It works !

The problem was in the implementation of the "NONE" pixel filter, I "simplified" the way it works and now Oidn recognize the noise and works with BIDir (no problem with Metropolis too):

bidir.jpg

Yuppie !

@B.Y.O.B.: you should always force the "film.filter.type = NONE" with BIDir+Oidn in BlendLuxCore.
Support LuxCoreRender project with salts and bounties
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci »

Dade wrote: Wed Feb 06, 2019 11:20 am It works !

The problem was in the implementation of the "NONE" pixel filter, I "simplified" the way it works and now Oidn recognize the noise and works with BIDir (no problem with Metropolis too):


bidir.jpg


Yuppie !

@B.Y.O.B.: you should always force the "film.filter.type = NONE" with BIDir+Oidn in BlendLuxCore.
Oh boy, this is amazing... is there a build?
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: OpenImageDenoise

Post by Dade »

lacilaci wrote: Wed Feb 06, 2019 11:25 am Oh boy, this is amazing... is there a build?
It is cooking: https://dev.azure.com/LuxCoreRender/Lux ... uildId=200
Support LuxCoreRender project with salts and bounties
User avatar
FarbigeWelt
Donor
Donor
Posts: 1046
Joined: Sun Jul 01, 2018 12:07 pm
Location: Switzerland
Contact:

Re: OpenImageDenoise

Post by FarbigeWelt »

Dade wrote: Wed Feb 06, 2019 11:20 am It works !
Congratulations, Dade!

And sure for all others involved in this exceptional performance.



(I am close to be speaklessly overwhelmd.)
Light and Word designing Creator - www.farbigewelt.ch - aka quantenkristall || #luxcorerender
MacBook Air with M1
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci »

Dade wrote: Wed Feb 06, 2019 11:27 am
lacilaci wrote: Wed Feb 06, 2019 11:25 am Oh boy, this is amazing... is there a build?
It is cooking: https://dev.azure.com/LuxCoreRender/Lux ... uildId=200
BTW, did you fix the unknown imagepipeline error for linux build? Windows works, and B.Y.O.B. own build worked yesterday aswell but azure linux didn't.

EDIT: To answer my own question, daily builds of linux no longer throw the error aobut uknown image pipeline when using oidn.
Last edited by lacilaci on Wed Feb 06, 2019 1:29 pm, edited 1 time in total.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: OpenImageDenoise

Post by B.Y.O.B. »

Awesome!
Dade wrote: Wed Feb 06, 2019 11:20 am @B.Y.O.B.: you should always force the "film.filter.type = NONE" with BIDir+Oidn in BlendLuxCore.
Done.

Here's a 64 sample render with Bidir + OIDN:
Attachments
d_noisy.png
d_denoised.png
epilectrolytics
Donor
Donor
Posts: 790
Joined: Thu Oct 04, 2018 6:06 am

Re: OpenImageDenoise

Post by epilectrolytics »

FarbigeWelt wrote: Wed Feb 06, 2019 11:45 am (I am close to be speaklessly overwhelmd.)
Possibly a divine intervention by JAHEW or SIHVA helped to make OIDN work :lol:
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci »

This is incredible... I might actually give bidir a try in some cases!
Post Reply