New Albedo settings and more Denoiser related changes

Discussion related to the LuxCore functionality, implementations and API.
daros
Posts: 163
Joined: Thu Dec 12, 2019 3:25 pm

Re: New Albedo settings and more Denoiser related changes

Post by daros » Thu Jul 08, 2021 7:10 am

This one is with prefiltering off...
no big difference regarding the transparencies
View 01 600x300newprefiltering off.png

User avatar
Dade
Developer
Posts: 5522
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New Albedo settings and more Denoiser related changes

Post by Dade » Thu Jul 08, 2021 11:08 am

daros wrote:
Wed Jul 07, 2021 11:27 am
latest oidn
View 01 1200x600B_1.jpg

unfortunately even the areas where oidn gets lost are very visible.
The only solution I see, for this kind of problems, is to increase the samples per pixel and/or increase the rendering resolution and than scale down the result. It is easy to test, if you render at 64/128/256 samples per pixel and increase the resolution 600/1200/2400 pixels, the problem fades away.

This is a problem somewhat specific of BiDir and having to disable pixel filtering because of OIDN (Path tracing uses a different kind of pixel filtering).

I'm playing with the idea of having a very special pre-processing of Albedo and Normal AOVs for BiDir: they can be computed very very fast by a dedicated rendering step instead of having them as side product of BiDir rendering.
The problem is BiDir has a very very low samples/sec speed and this affect the quality of Albedo and Normal AOVs. If I render them in a dedicated step with a lot more samples it should improve the quality of the denoise output with a very little cost.
Support LuxCoreRender project with salts and bounties

User avatar
Dade
Developer
Posts: 5522
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New Albedo settings and more Denoiser related changes

Post by Dade » Thu Jul 08, 2021 11:22 am

daros wrote:
Thu Jul 08, 2021 7:10 am
This one is with prefiltering off...
no big difference regarding the transparencies

View 01 600x300newprefiltering off.png
I think I can fix this problem:

normal.jpg

See the normal AOV ? It uses the normal of the glass instead of the normal of the surfaces seen trough the glass (so it is not aligned with the Albedo AOV).
I need to have for normal AOV the same setting I have for Albedo AOV.
Support LuxCoreRender project with salts and bounties

daros
Posts: 163
Joined: Thu Dec 12, 2019 3:25 pm

Re: New Albedo settings and more Denoiser related changes

Post by daros » Thu Jul 08, 2021 10:54 pm

great!

User avatar
FarbigeWelt
Donor
Posts: 1033
Joined: Sun Jul 01, 2018 12:07 pm
Location: Switzerland
Contact:

Re: New Albedo settings and more Denoiser related changes

Post by FarbigeWelt » Fri Jul 09, 2021 7:12 pm

Dade wrote:
Thu Jul 08, 2021 11:08 am
I'm playing with the idea of having a very special pre-processing of Albedo and Normal AOVs for BiDir: they can be computed very very fast by a dedicated rendering step instead of having them as side product of BiDir rendering.
The problem is BiDir has a very very low samples/sec speed and this affect the quality of Albedo and Normal AOVs. If I render them in a dedicated step with a lot more samples it should improve the quality of the denoise output with a very little cost.
This sounds great! :D Please, enhance BiDir with this special pre-processing. Many of BiDir addicts will very appreciate this enhancement.
I' am sure about this one. :mrgreen: :geek:
Light and Word designing Creator - www.farbigewelt.ch - aka quantenkristall || #luxcorerender
Windows 10 Pro 64 || 2x16 Cores, AMD Ryzen 3950X @3.5GHz, 64 GB RAM, DDR4 @3.2 GHz
2x openCL, AMD Radeon RX 5700 XT, 8 GB VRAM || Gfp = SFFT Gflops

User avatar
Dade
Developer
Posts: 5522
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New Albedo settings and more Denoiser related changes

Post by Dade » Sat Jul 10, 2021 11:20 am

Now the Normal AOV is consistent with Albedo AOV settings (compare with my previous post):

n1.jpg

I have also added the pre-filtering of normal pass because it can now noise as albedo.

I will now check if I can get something out of the idea of a pre-rendering of Albedo and Normal AOVs.
Support LuxCoreRender project with salts and bounties

Martini
Posts: 114
Joined: Fri Nov 23, 2018 11:36 am
Location: Australia

Re: New Albedo settings and more Denoiser related changes

Post by Martini » Sat Jul 10, 2021 12:28 pm

Dade wrote:
Sat Jul 10, 2021 11:20 am
Now the Normal AOV is consistent with Albedo AOV settings (compare with my previous post):

n1.jpg
I'm sure I'm not reading this correctly, but is this part of the normals correct? Looks a bit strange to me. :?
shading-normal.png
i9 9900K @ 5000MHz | 2x Gigabyte AORUS RTX 2080 Ti Extreme Waterforce WB 11G @ 2010MHz
Z390 Aorus Pro | 32GB Kingston HyperX Predator RGB @ 4300MHz

User avatar
Dade
Developer
Posts: 5522
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New Albedo settings and more Denoiser related changes

Post by Dade » Sat Jul 10, 2021 12:59 pm

Martini wrote:
Sat Jul 10, 2021 12:28 pm
I'm sure I'm not reading this correctly, but is this part of the normals correct? Looks a bit strange to me. :?

Yes, it is the reflection of the side (glass both reflect and transmit and Albedo and Normal AOVs show that).
Support LuxCoreRender project with salts and bounties

Martini
Posts: 114
Joined: Fri Nov 23, 2018 11:36 am
Location: Australia

Re: New Albedo settings and more Denoiser related changes

Post by Martini » Sat Jul 10, 2021 1:04 pm

Dade wrote:
Sat Jul 10, 2021 12:59 pm
Martini wrote:
Sat Jul 10, 2021 12:28 pm
I'm sure I'm not reading this correctly, but is this part of the normals correct? Looks a bit strange to me. :?

Yes, it is the reflection of the side (glass both reflect and transmit and Albedo and Normal AOVs show that).
Ah of course. Thanks for clarifying :mrgreen:
i9 9900K @ 5000MHz | 2x Gigabyte AORUS RTX 2080 Ti Extreme Waterforce WB 11G @ 2010MHz
Z390 Aorus Pro | 32GB Kingston HyperX Predator RGB @ 4300MHz

bartek_zgo
Posts: 81
Joined: Mon Oct 26, 2020 11:42 am

Re: New Albedo settings and more Denoiser related changes

Post by bartek_zgo » Tue Jul 20, 2021 8:57 am

Today I have updated our luxcore to latest commit. Unfortunately I do not see any improvement with denoiser.
With high quality it looks the same. The same problems with carpet.
Old (updated on 7'th Jully):
prev lux.png
New (updated today):
new lux.png
With low quality glass looks even worse.
Old
previous_glass.png
New
new_glass.png

Post Reply