Page 2 of 6

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 3:01 pm
by juangea
Have you implemented also the option to assume that the Albedo is 100% clean? The one that does not prefilter the Albedo and uses it directly as fully clean

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 3:59 pm
by B.Y.O.B.
To make the test more informative, it would be good to add a ground truth (high sample count without denoising), then we could compare which denoised result resembles the ground truth best.

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 4:57 pm
by juangea
But in this case, that scene is not a noise heavy scene with a lot of Albedos, there are more transmissive and specular materials, and small dielectric with small albedos.

A scene with cloth, small fine cloth detail in a sofa cloth or a wooden floor with a lot of wood detail, that's the type of scene what will benefit from this, we are working in a project where we can test this, in fact I have a 360 visit where the effects of loosing detail are very clear, and with this, that could be improved a lot :)

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 5:12 pm
by CodeHD
I would also rate is as an improvement in most areas. On the plate, it looks like sometimes there can be inverse behavior between some regions.
Since the undenoised result is always available, I guess it should be possible to recalculate after rendering is finished. Thats probably on the BlendLuxCore side of implementations though?

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 5:37 pm
by TAO
I think Dade already implement OIDN 1.4 in LuxCore 2.6.

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 5:58 pm
by juangea
Yep, I was asking about BlendLuxCore, the Blender Addon, it needs some touches for sure to be able to enable the pre-filter or the clean Albedo options :)

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 6:24 pm
by Dade
juangea wrote: Tue May 25, 2021 5:58 pm Yep, I was asking about BlendLuxCore, the Blender Addon, it needs some touches for sure to be able to enable the pre-filter or the clean Albedo options :)
Albedo pre-filtering is enabled by default and done on the fly by the new image pipeline OIDN plugin code (so I think there is no need to affect or of a duplicate Albedo AOV). It should work all out of the box.

I assume there is no need to not pre-filter Albedo (aka pre-filtering an already clear Albedo pass should have no effects or harm) :?:

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue May 25, 2021 7:05 pm
by juangea
No, there should not be harm, but there could be some benefit of using the non-filtered Albedo as a filtered one, specially because there may be parts of the Albedo that could be destroyed by the filter, or because a bit of noise in the Albedo could generate an interesting detail retention (grain-like) effect.
I’m not sure because I have not tested it, but maybe.

I’ll update BlendLuxCore later and test it in our current scene :)

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Fri May 28, 2021 1:48 pm
by juangea
I did a quick test but weirdly enough I see no difference in our scene.

In fact I compared the Denoised pass result in 2.92 with 2.6 alpha vs the denoised result of the Denoise node and the result was exactly the same, I may have did something wrong doig the update, I'll check again and say something.

Re: New OIDN 1.4 with new features and better detail preservation

Posted: Tue Jun 01, 2021 6:35 am
by Dez!
Image
32 sempl