New OIDN 1.4 with new features and better detail preservation

Discussion related to the LuxCore functionality, implementations and API.
User avatar
B.Y.O.B.
Developer
Posts: 4124
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: New OIDN 1.4 with new features and better detail preservation

Post by B.Y.O.B. » Wed Jun 23, 2021 2:35 pm

kintuX wrote:
Wed Jun 23, 2021 1:23 pm
B.Y.O.B. wrote:
Wed Jun 23, 2021 12:50 pm
Switch what?
For OIDN to use "Shading normal" instead of "Avg." pass.
No, it's not possible to change that. OIDN can only work with the averaged normals.

kintuX
Posts: 707
Joined: Wed Jan 10, 2018 2:37 am

Re: New OIDN 1.4 with new features and better detail preservation

Post by kintuX » Wed Jun 23, 2021 10:41 pm

B.Y.O.B. wrote:
Wed Jun 23, 2021 2:35 pm
kintuX wrote:
Wed Jun 23, 2021 1:23 pm
B.Y.O.B. wrote:
Wed Jun 23, 2021 12:50 pm
Switch what?
For OIDN to use "Shading normal" instead of "Avg." pass.
No, it's not possible to change that. OIDN can only work with the averaged normals.
Oh, so... :shock: baad :| ...no fine details preserved :( either way, maybe sooner or later but in meantime, it would really be nice to have choices/options juangea mentioned available :D

User avatar
B.Y.O.B.
Developer
Posts: 4124
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: New OIDN 1.4 with new features and better detail preservation

Post by B.Y.O.B. » Wed Jun 23, 2021 11:47 pm

It's not bad. I have a feeling you don't understand what the difference between the two pass types is?

User avatar
Dade
Developer
Posts: 5523
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New OIDN 1.4 with new features and better detail preservation

Post by Dade » Thu Jun 24, 2021 11:03 am

Ok, this is what I found.

This is a rendering with 100 spp:

pf0.jpg

There is clearly a filtering problem (i.e. the moire effect).

Even more samples per pixel will not help, this is a 1000 spp rendering:

pf1.jpg

However, if I re-enable pixel filtering (note: disabled because of OIDN requirement), even a 100 spp rendering is a lot better:

pf2.jpg

So I tried to just use ODIN with pixel filter enabled and the result looks a lot better. This is a 100spp rendering (first is raw, second is denoised without pixel filtering, the latest is denoised with pixel filtering):

i0.jpg
i1.jpg
i2.jpg

I would say that latest is a far better denoised result. We clearly need to have pixel filtering enabled, at least on Normal pass.

Unfortunately, because the why pixel filtering works, I can not conditional filtering on some AOV and not on others (I would have to literally render the image multiple times).

At the moment, my conclusion is that we should re-enable pixel filtering for path tracing + ODIN. BiDir should probably stay like it is because, I'm pretty sure, the way pixel filtering work in BiDir will drive OIDN crazy.
Support LuxCoreRender project with salts and bounties

juangea
Donor
Posts: 328
Joined: Thu Jan 02, 2020 6:23 pm

Re: New OIDN 1.4 with new features and better detail preservation

Post by juangea » Thu Jun 24, 2021 2:19 pm

Without any doubt the filtered image is way better.

A good test could be to have lit and shadow zones, with a sun, also inside an interior.

Have you tested with the albedo being considered like perfectly clean?

I think that should improve the result too, specially in complex scenes where the cloth patter is lost, like the pictures I showed before.

User avatar
Dade
Developer
Posts: 5523
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New OIDN 1.4 with new features and better detail preservation

Post by Dade » Thu Jun 24, 2021 3:06 pm

juangea wrote:
Thu Jun 24, 2021 2:19 pm
Have you tested with the albedo being considered like perfectly clean?
Albedo is pre-filtered in v2.6 so yes. I have also tried to pre-filter the normal pass to see if it helps but it only increases the "blurriness" of the end result.
Support LuxCoreRender project with salts and bounties

juangea
Donor
Posts: 328
Joined: Thu Jan 02, 2020 6:23 pm

Re: New OIDN 1.4 with new features and better detail preservation

Post by juangea » Thu Jun 24, 2021 8:50 pm

No, I mean the mode where it considers the Albedo as noise clean but without prefiltering.

AFAIK 1.4 has three nodes:

- As before
- Prefiltering Albedo
- Consider Albedo as prefiltered (noise free) but without prefiltering it.

In situations with fine detail like this one, but where you don’t have normals, it may be possible that you want Albedo but no bump, you may loose a lot of detail with the prefiltering, because it considers the texture detail as noise.

So what I mean is the third mode, where the Albedo is not prefiltered but is considered as noise free.

juangea
Donor
Posts: 328
Joined: Thu Jan 02, 2020 6:23 pm

Re: New OIDN 1.4 with new features and better detail preservation

Post by juangea » Thu Jun 24, 2021 8:59 pm

I’ve been looking at the API here:

https://github.com/OpenImageDenoise/oid ... readme.pdf

I mean the CleanAUX filter parameter.

kintuX
Posts: 707
Joined: Wed Jan 10, 2018 2:37 am

Re: New OIDN 1.4 with new features and better detail preservation

Post by kintuX » Fri Jun 25, 2021 9:14 am

B.Y.O.B. wrote:
Wed Jun 23, 2021 11:47 pm
It's not bad. I have a feeling you don't understand what the difference between the two pass types is?
Yeah, it's good. I was aiming for too fine detail (almost subpixel size).

acasta69
Developer
Posts: 436
Joined: Tue Jan 09, 2018 3:45 pm
Location: Italy

Re: New OIDN 1.4 with new features and better detail preservation

Post by acasta69 » Thu Jul 15, 2021 7:27 am

juangea wrote:
Wed Jun 23, 2021 2:04 pm
One important thing regarding OIDN 1.4.1:

chrome_FNaHVXsBJW.png
I think we are still on OIDN 1.4.0. Should we do this upgrade :?:
Support LuxCoreRender project with salts and bounties

Windows 10 64 bits, i7-4770 3.4 GHz, RAM 16 GB, GTX 970 4GB v445.87

Post Reply