Page 5 of 7

Re: Denoiser Integration

Posted: Wed May 09, 2018 7:07 am
by B.Y.O.B.
Luxart wrote: Wed May 09, 2018 6:32 am Is BCD main denoising code implemented in opencl or only CPU

If only CPU is it Multithreaded
The authors offer CPU and CUDA implementations.
We are only using the CPU version.
It is multithreaded.

Re: Denoiser Integration

Posted: Wed May 09, 2018 7:47 am
by Luxart
B.Y.O.B. wrote: Wed May 09, 2018 7:07 am
Luxart wrote: Wed May 09, 2018 6:32 am Is BCD main denoising code implemented in opencl or only CPU

If only CPU is it Multithreaded
The authors offer CPU and CUDA implementations.
We are only using the CPU version.
It is multithreaded.
Thanks for the info.

Re: Denoiser Integration

Posted: Wed May 09, 2018 7:49 am
by Luxart
marcatore wrote: Wed May 09, 2018 7:04 am
Well, 20secs for an image... when the alternative (no denoiser) is to wait minutes or hours to have the same "noisefree" level... is this real a problem? :)
I know it is faster. What I want to know was, if it is implemented in OpenCL.

As BYOB mentioned it is CPU multithreaded. If it was in OpenCL(may be in future) it would be much faster (may be 5 secs) :) .

Re: Denoiser Integration

Posted: Wed May 09, 2018 8:43 am
by Asticles
Have a question, blender denoise removes fireflies. How is handling fireflies this denoise function?

Thanks

Re: Denoiser Integration

Posted: Wed May 09, 2018 9:17 am
by Dade
Asticles wrote: Wed May 09, 2018 8:43 am Have a question, blender denoise removes fireflies. How is handling fireflies this denoise function?
We have variance clamping for that task :idea:

Re: Denoiser Integration

Posted: Wed May 09, 2018 10:30 am
by Asticles
Dade wrote: Wed May 09, 2018 9:17 am
Asticles wrote: Wed May 09, 2018 8:43 am Have a question, blender denoise removes fireflies. How is handling fireflies this denoise function?
We have variance clamping for that task :idea:
Of course! ;) But In the case of cycles, this seems to be a happy side effect. I was just asking what happens to fireflies, in case it appears one when not using variance clamping properly (or not so accurately).

Re: Denoiser Integration

Posted: Wed May 09, 2018 11:04 am
by Dade
Asticles wrote: Wed May 09, 2018 10:30 am Of course! ;) But In the case of cycles, this seems to be a happy side effect. I was just asking what happens to fireflies, in case it appears one when not using variance clamping properly (or not so accurately).
They are usually smoothed but not removed.

Re: Denoiser Integration

Posted: Thu May 10, 2018 9:17 am
by Dade
Did I ever said how damn well this thing works ? :lol:
scr.jpg
A 10 mins rendering, it makes animations possible.

Re: Denoiser Integration

Posted: Thu May 10, 2018 10:35 am
by marcatore
yes..it's working good. :)

I'm impatient to test it in my test scene... :)

Re: Denoiser Integration

Posted: Thu May 10, 2018 4:45 pm
by B.Y.O.B.
Dade wrote: Thu May 10, 2018 9:17 am A 10 mins rendering, it makes animations possible.
Let's first test how bad the flickering will be.