Denoiser Integration

Discussion related to the Engine functionality, implementations and API.
User avatar
B.Y.O.B.
Developer
Posts: 1585
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Denoiser Integration

Post by B.Y.O.B. » Wed May 09, 2018 7:07 am

Luxart wrote:
Wed May 09, 2018 6:32 am
Is BCD main denoising code implemented in opencl or only CPU

If only CPU is it Multithreaded
The authors offer CPU and CUDA implementations.
We are only using the CPU version.
It is multithreaded.
Support LuxCoreRender project with salts and bounties

Luxart
Posts: 41
Joined: Tue Feb 13, 2018 10:14 am

Re: Denoiser Integration

Post by Luxart » Wed May 09, 2018 7:47 am

B.Y.O.B. wrote:
Wed May 09, 2018 7:07 am
Luxart wrote:
Wed May 09, 2018 6:32 am
Is BCD main denoising code implemented in opencl or only CPU

If only CPU is it Multithreaded
The authors offer CPU and CUDA implementations.
We are only using the CPU version.
It is multithreaded.
Thanks for the info.

Luxart
Posts: 41
Joined: Tue Feb 13, 2018 10:14 am

Re: Denoiser Integration

Post by Luxart » Wed May 09, 2018 7:49 am

marcatore wrote:
Wed May 09, 2018 7:04 am

Well, 20secs for an image... when the alternative (no denoiser) is to wait minutes or hours to have the same "noisefree" level... is this real a problem? :)
I know it is faster. What I want to know was, if it is implemented in OpenCL.

As BYOB mentioned it is CPU multithreaded. If it was in OpenCL(may be in future) it would be much faster (may be 5 secs) :) .

Asticles
Posts: 120
Joined: Thu Jan 11, 2018 8:52 am

Re: Denoiser Integration

Post by Asticles » Wed May 09, 2018 8:43 am

Have a question, blender denoise removes fireflies. How is handling fireflies this denoise function?

Thanks
Salvador Ureña

User avatar
Dade
Developer
Posts: 1330
Joined: Mon Dec 04, 2017 8:36 pm

Re: Denoiser Integration

Post by Dade » Wed May 09, 2018 9:17 am

Asticles wrote:
Wed May 09, 2018 8:43 am
Have a question, blender denoise removes fireflies. How is handling fireflies this denoise function?
We have variance clamping for that task :idea:
Support LuxCoreRender project with salts and bounties

Asticles
Posts: 120
Joined: Thu Jan 11, 2018 8:52 am

Re: Denoiser Integration

Post by Asticles » Wed May 09, 2018 10:30 am

Dade wrote:
Wed May 09, 2018 9:17 am
Asticles wrote:
Wed May 09, 2018 8:43 am
Have a question, blender denoise removes fireflies. How is handling fireflies this denoise function?
We have variance clamping for that task :idea:
Of course! ;) But In the case of cycles, this seems to be a happy side effect. I was just asking what happens to fireflies, in case it appears one when not using variance clamping properly (or not so accurately).
Salvador Ureña

User avatar
Dade
Developer
Posts: 1330
Joined: Mon Dec 04, 2017 8:36 pm

Re: Denoiser Integration

Post by Dade » Wed May 09, 2018 11:04 am

Asticles wrote:
Wed May 09, 2018 10:30 am
Of course! ;) But In the case of cycles, this seems to be a happy side effect. I was just asking what happens to fireflies, in case it appears one when not using variance clamping properly (or not so accurately).
They are usually smoothed but not removed.
Support LuxCoreRender project with salts and bounties

User avatar
Dade
Developer
Posts: 1330
Joined: Mon Dec 04, 2017 8:36 pm

Re: Denoiser Integration

Post by Dade » Thu May 10, 2018 9:17 am

Did I ever said how damn well this thing works ? :lol:
scr.jpg
A 10 mins rendering, it makes animations possible.
Support LuxCoreRender project with salts and bounties

marcatore
Posts: 110
Joined: Wed Jan 10, 2018 8:04 am

Re: Denoiser Integration

Post by marcatore » Thu May 10, 2018 10:35 am

yes..it's working good. :)

I'm impatient to test it in my test scene... :)

User avatar
B.Y.O.B.
Developer
Posts: 1585
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Denoiser Integration

Post by B.Y.O.B. » Thu May 10, 2018 4:45 pm

Dade wrote:
Thu May 10, 2018 9:17 am
A 10 mins rendering, it makes animations possible.
Let's first test how bad the flickering will be.
Support LuxCoreRender project with salts and bounties

Post Reply