Line endings

Discussion related to the LuxCore functionality, implementations and API.
Post Reply
jensverwiebe
Supporting Users
Posts: 141
Joined: Tue Jan 09, 2018 6:48 pm

Line endings

Post by jensverwiebe »

I recently found some files line endings borked on linux ( touched with windows ? )
I suggest adding * text=auto to .gitattributes
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Line endings

Post by Dade »

jensverwiebe wrote: Thu Feb 22, 2018 11:29 am I recently found some files line endings borked on linux ( touched with windows ? )
I suggest adding * text=auto to .gitattributes
It is the default as far as I remember :?:

I had exactly the opposite problem with Git replacing CR/LF in .ply (binary format) and corrupting the files. So I had to add https://github.com/LuxCoreRender/LuxCor ... attributes to consider .ply binaries.
Support LuxCoreRender project with salts and bounties
jensverwiebe
Supporting Users
Posts: 141
Joined: Tue Jan 09, 2018 6:48 pm

Re: Line endings

Post by jensverwiebe »

Dade wrote: Thu Feb 22, 2018 11:58 am
jensverwiebe wrote: Thu Feb 22, 2018 11:29 am I recently found some files line endings borked on linux ( touched with windows ? )
I suggest adding * text=auto to .gitattributes
It is the default as far as I remember :?:

I had exactly the opposite problem with Git replacing CR/LF in .ply (binary format) and corrupting the files. So I had to add https://github.com/LuxCoreRender/LuxCor ... attributes to consider .ply binaries.
Okay, seems * text=auto can be avoided.
I configured my git as per: https://help.github.com/articles/dealin ... e-endings/
with git config --global core.autocrlf input

Now my diffs look okay with fresh clone.
Post Reply