Disney Material Update

Discussion related to the LuxCore functionality, implementations and API.
User avatar
Dade
Developer
Posts: 5547
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Disney Material Update

Post by Dade » Wed Aug 18, 2021 1:49 pm

chuchur wrote:
Wed Aug 18, 2021 1:36 pm
I just wonder what kind of event types i could use for Disney in GetEventTypes and Sample/Evaluate methods?

For Glass material we have SPECULAR | REFLECT| TRANSMIT and for Disney without transmission we have GLOSSY|REFLECT.
GetEventTypes() should return all type of events possible. In your case, it should be GLOSSY|REFLECT or GLOSSY|REFLECT|TRANSMIT if the transmission texture is not black.
chuchur wrote:
Wed Aug 18, 2021 1:36 pm
Should it be for Disney with transmission GLOSSY|SPECULAR|REFLECT| TRANSMIT in GetEventTypes ?
As far as I remember the Disney transmission is still glossy, not specular. Don't they use some kind of GGX distribution for transmission too ? To have rough glass, etc. ?
chuchur wrote:
Wed Aug 18, 2021 1:36 pm
And in Sample/Evaluate GLOSSY|REFLECT for reflected path and SPECULAR|TRANSMIT for refracted path?
Yes, Sample/Evaluate events are what actually happen in this specific call (aside from the Glossy Vs Specular transmission detail I don't remember).
Support LuxCoreRender project with salts and bounties

chuchur
Posts: 26
Joined: Tue Sep 15, 2020 8:44 am

Re: Disney Material Update

Post by chuchur » Wed Aug 18, 2021 2:14 pm

Don't they use some kind of GGX distribution for transmission too ?
you are right, it is SampleGgxVndfAnisotropic. So, I'll take GLOSSY|REFLECT|TRANSMIT for GetEventTypes.

I guess I've almost finished the CPU part. Hope, I could commit my code soon.

User avatar
Sharlybg
Donor
Posts: 2939
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: Disney Material Update

Post by Sharlybg » Wed Aug 18, 2021 6:57 pm

chuchur wrote:
Wed Aug 18, 2021 2:14 pm
Don't they use some kind of GGX distribution for transmission too ?
you are right, it is SampleGgxVndfAnisotropic. So, I'll take GLOSSY|REFLECT|TRANSMIT for GetEventTypes.

I guess I've almost finished the CPU part. Hope, I could commit my code soon.
Really Nice to see Help in this area ;) Bravo
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA

chuchur
Posts: 26
Joined: Tue Sep 15, 2020 8:44 am

Re: Disney Material Update

Post by chuchur » Thu Aug 19, 2021 12:07 pm

Sharlybg and Dade,

thank you for your motivation! I'll come next week back from the holidays to make it final :D

juangea
Donor
Posts: 328
Joined: Thu Jan 02, 2020 6:23 pm

Re: Disney Material Update

Post by juangea » Wed Aug 25, 2021 11:20 am

Thanks for this Churchur! this will be helpful for sure! :D

chuchur
Posts: 26
Joined: Tue Sep 15, 2020 8:44 am

Re: Disney Material Update

Post by chuchur » Mon Oct 11, 2021 9:18 am

Hi! I'm sorry for my long absence (was busy with work project).

I'm transferring slowly math from Selas Project https://github.com/schuttejoe/Selas https://github.com/schuttejoe/Selas/blo ... Disney.cpp) into Lux.

Just want to be sure I'm doing all right:

Do we have axis Z normal to the surface direction? In Selas it is Y.

User avatar
Dade
Developer
Posts: 5547
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Disney Material Update

Post by Dade » Mon Oct 11, 2021 9:33 am

chuchur wrote:
Mon Oct 11, 2021 9:18 am
Do we have axis Z normal to the surface direction? In Selas it is Y.
Yes, it is like PBRT.
Support LuxCoreRender project with salts and bounties

Post Reply