New OIDN 1.4 with new features and better detail preservation

Discussion related to the LuxCore functionality, implementations and API.
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New OIDN 1.4 with new features and better detail preservation

Post by Dade »

Can you post a cube scene with that material ?
Support LuxCoreRender project with salts and bounties
juangea
Donor
Donor
Posts: 332
Joined: Thu Jan 02, 2020 6:23 pm

Re: New OIDN 1.4 with new features and better detail preservation

Post by juangea »

I sent you the file with the asset and materials / textures in a PM :)
kintuX
Posts: 809
Joined: Wed Jan 10, 2018 2:37 am

Re: New OIDN 1.4 with new features and better detail preservation

Post by kintuX »

Is it correct to totally disregard SHADING NORMAL pass & denoises anyway?

Eg.
Gold w Bump (Normal map), rendered to 5k samples (Halt Noise Treshold @ 6).
Attachments
Metal-Nrml_RAW.jpg
Metal-Nrml_OIDN1.4.jpg
Metal-Nrml_SHDNG-NRML.jpg
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: New OIDN 1.4 with new features and better detail preservation

Post by Dade »

In latest sources and with OIDN v1.4, I'm pre-filtering only the Albedo pass but looking at the images I'm starting to think that it may be worth pre-filtering the normal pass too. I will do some test.
Support LuxCoreRender project with salts and bounties
juangea
Donor
Donor
Posts: 332
Joined: Thu Jan 02, 2020 6:23 pm

Re: New OIDN 1.4 with new features and better detail preservation

Post by juangea »

I think that looking at the results, the best course of action would be to give the user all the options, so there is a default behavior, but the user can go and decide what happens with each pass and how OIDN should treat them.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: New OIDN 1.4 with new features and better detail preservation

Post by B.Y.O.B. »

kintuX wrote: Wed Jun 23, 2021 10:50 am Is it correct to totally disregard SHADING NORMAL pass & denoises anyway?
OIDN uses the Avg. Shading Normal pass (Avg. = Average).
In the Blender addon, it is enabled automatically behind the scenes when the denoiser is used.
kintuX
Posts: 809
Joined: Wed Jan 10, 2018 2:37 am

Re: New OIDN 1.4 with new features and better detail preservation

Post by kintuX »

B.Y.O.B. wrote: Wed Jun 23, 2021 11:32 am
kintuX wrote: Wed Jun 23, 2021 10:50 am Is it correct to totally disregard SHADING NORMAL pass & denoises anyway?
OIDN uses the Avg. Shading Normal pass (Avg. = Average).
In the Blender addon, it is enabled automatically behind the scenes when the denoiser is used.
Oh, so that's why details are gone. (Yes, avg. nrml pass was smooth)
Is there a simple way to switch it?
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: New OIDN 1.4 with new features and better detail preservation

Post by B.Y.O.B. »

Switch what?
kintuX
Posts: 809
Joined: Wed Jan 10, 2018 2:37 am

Re: New OIDN 1.4 with new features and better detail preservation

Post by kintuX »

B.Y.O.B. wrote: Wed Jun 23, 2021 12:50 pmSwitch what?
For OIDN to use "Shading normal" instead of "Avg." pass.
juangea
Donor
Donor
Posts: 332
Joined: Thu Jan 02, 2020 6:23 pm

Re: New OIDN 1.4 with new features and better detail preservation

Post by juangea »

One important thing regarding OIDN 1.4.1:
chrome_FNaHVXsBJW.png
Post Reply