Page 3 of 3

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 7:23 am
by Dade
Can you redo test with the sun enabled ? I'm curious of the outcome.

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 7:38 am
by marcatore
always with 1 sampling path?
So, I open the scene I shared, enable sun&sky and and stop?

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 7:40 am
by Dade
marcatore wrote: Thu Jul 05, 2018 7:38 am always with 1 sampling path?
So, I open the scene I shared, enable sun&sky and and stop?
Yes but with the fix to the number of light sources :mrgreen:

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 7:42 am
by B.Y.O.B.
I'm currently rendering it with sun+sky and 5 diffuse/glossy/spec/total path depth.
edit: here it is.

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 7:48 am
by marcatore
Dade wrote: Thu Jul 05, 2018 7:40 am
marcatore wrote: Thu Jul 05, 2018 7:38 am always with 1 sampling path?
So, I open the scene I shared, enable sun&sky and and stop?
Yes but with the fix to the number of light sources :mrgreen:
I'm already using the default value :)

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 7:54 am
by marcatore
Here we are
This is with sun enabled 2min22sec (total time)
SunSky.jpg
This is with double resolution (actually my daily output resolution) 33min total time ( total depth 8, diffuse&glossy&specular 4)
LightCache_noEmissionOnLights_33min.jpg
This is the denoised image
LightCache_noEmissionOnLights_33min_3minDenoised.jpg
I'd like to save the lightcache solution, load it and render this scene with GPU.... :)

In any case a great improvement for this kind of scenarios.
Great job

edit: I didn't understand how to denoise the image with different settings after the render is finished. The "run denoiser" button is always grey (disabled)

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 8:19 am
by B.Y.O.B.
marcatore wrote: Thu Jul 05, 2018 7:54 am edit: I didn't understand how to denoise the image with different settings after the render is finished. The "run denoiser" button is always grey (disabled)
Denoising after the render is finished is not possible.
I'd like to say "currently" but I fear it is not really solvable because of Blender API limitations (see https://github.com/LuxCoreRender/BlendL ... -398390095)

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 8:27 am
by marcatore
So, if I'd like to test different settings, what should be the workflow?

Something like:
- launch render
- when I'm quite satisfied of the sampling, I press Pause of the render
- then in the image editor I change the denoiser settings

is it correct?

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 8:37 am
by Dade
It works quite well, good.
marcatore wrote: Thu Jul 05, 2018 7:54 am I'd like to save the lightcache solution, load it and render this scene with GPU.... :)
I'm going to add the option to have persistent light cache, saved on file: for camera-only animations it will be possible to use the same cache for all frames. OpenCL support will be the next step once things are settle down.

Re: Direct Light cache: hit rate not good

Posted: Thu Jul 05, 2018 8:44 am
by B.Y.O.B.
marcatore wrote: Thu Jul 05, 2018 8:27 am Something like:
- launch render
- when I'm quite satisfied of the sampling, I press Pause of the render
- then in the image editor I change the denoiser settings

is it correct?
Yes.