Noise threshold, no clue what's happening

Use this forum for general user support and related questions.
Forum rules
Please upload a testscene that allows developers to reproduce the problem, and attach some images.
kintuX
Posts: 669
Joined: Wed Jan 10, 2018 2:37 am

Re: Noise threshold, no clue what's happening

Post by kintuX » Wed May 19, 2021 6:38 pm

juangea wrote:
Tue May 18, 2021 5:09 pm
The thing is that in Blender we cannot put more than 255 I think.

@Theverat should know better I imagine.

P.S.: Yep, I just confirmed, in Blender the maximum value is 255, we cannot configure higher values.

P.S.2.: To Theverat (BYOB) I just changed the maximum limit of Noise Threshold from "max" to "soft_max" to allow freedom in maxmium written value, may be a thing to consider so the gates are open for custom values, what do you think?
Care to reveal: "How to?"
Or better yet, if possible, grow your branch with changes on BlendLuxCore repo and make pull request?

juangea
Donor
Posts: 309
Joined: Thu Jan 02, 2020 6:23 pm

Re: Noise threshold, no clue what's happening

Post by juangea » Wed May 19, 2021 7:15 pm

Oh, I don't have a branch, I just modified the code in the addon installed in my blender, I'll tell you later the file and the line :)

juangea
Donor
Posts: 309
Joined: Thu Jan 02, 2020 6:23 pm

Re: Noise threshold, no clue what's happening

Post by juangea » Wed May 19, 2021 7:52 pm

OK, the file I changed was

Code: Select all

properties/halt.py
And there the line you need to change is the line 62, you will see this:

Code: Select all

noise_thresh: IntProperty(name="Noise Threshold", default=5, min=0, soft_min=3, max=255,
                               description=NOISE_THRESH_DESC)
Change the

Code: Select all

max=255
with a

Code: Select all

soft_max=255
and that's it :)

kintuX
Posts: 669
Joined: Wed Jan 10, 2018 2:37 am

Re: Noise threshold, no clue what's happening

Post by kintuX » Wed May 19, 2021 9:34 pm

oh, now that you've pointed it out, it really looks obvious
thanks for opening my eyes (+ giving me motivation to further learn to read code) 8-)

juangea
Donor
Posts: 309
Joined: Thu Jan 02, 2020 6:23 pm

Re: Noise threshold, no clue what's happening

Post by juangea » Wed May 19, 2021 9:54 pm

My pleasure :)

Post Reply