Search found 171 matches
- Sun Feb 03, 2019 2:24 pm
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
But I guess calculating the needed AOV's on demand and feed that to OIDN is simpler and probably enough. Is that ok? EDIT: Only saw your second post now, I will have a look on how it works. You are going to need to translate the ALBEDO and AVG_NORMAL_SHADING AOVs in a format suitable for Oidn: they...
- Sun Feb 03, 2019 1:57 pm
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
Is there support for imagepipeline plugins to receive multiple films as input? Looking at the ImagePipelinePlugin class it seems there is not, should it be extended to receive multiple Films? What do you mean ? A film can have one or more image pipelines and each image pipeline can have any number ...
- Sun Feb 03, 2019 1:47 pm
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
Is there support for imagepipeline plugins to receive multiple films as input?
Looking at the ImagePipelinePlugin class it seems there is not, should it be extended to receive multiple Films?
EDIT:
I guess I could also hardcode the IntelOIDN class to calculate the needed AOV's internally
Looking at the ImagePipelinePlugin class it seems there is not, should it be extended to receive multiple Films?
EDIT:
I guess I could also hardcode the IntelOIDN class to calculate the needed AOV's internally
- Sun Feb 03, 2019 1:36 pm
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
It has some weird stripe pattern :lol: The problem is in this kind of loop: for (u_int i = 0; i < pixelCount; i += 3) { color[i] = pixels[i].c[0]; color[i + 1] = pixels[i].c[1]; color[i + 2] = pixels[i].c[2]; } It should be something like: for (u_int i = 0; i < pixelCount; ++i) { const i3 = i * 3; ...
- Sun Feb 03, 2019 1:10 pm
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
I would put the gamma correction after the denoising step, but otherwise, I can't find anything wrong. I'll try to compile your branch on my machine. I just noticed that I was assuming that the Film would be tonemapped, the filter is even set up for LDR, but maybe that's not true. Since there is no...
- Sun Feb 03, 2019 12:18 pm
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
film.imagepipelines.1.0.type = GAMMA_CORRECTION film.imagepipelines.1.0.value = 2.2 film.imagepipelines.1.1.type = INTEL_OIDN I would put the gamma correction after the denoising step, but otherwise, I can't find anything wrong. I'll try to compile your branch on my machine. I just noticed that I w...
- Sun Feb 03, 2019 12:06 pm
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
In their example, they check for errors after the filter is executed, not before: https://github.com/OpenImageDenoise/oidn#c11-api-example The example in the repo itself was executing before. In any case I've put it after the filter execution and it didn't throw anything. When we did the BCD integr...
- Sun Feb 03, 2019 11:32 am
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
Syntax error in texture name: 0,75 0,75 0,75 Why are these numbers using commas instead of decimal points? This might be the issue (i.e. locale). https://github.com/LuxCoreRender/LuxCore/issues/103 Just opened the file and they're not using commas. It must be related to this bug EDIT: I should prob...
- Sun Feb 03, 2019 11:29 am
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
Giving the scene to LuxcoreUI as a command line argument makes it render correctly.
I've set-up a second image pipeline but it doesn't change the image in any way, even though it becomes very slow and something is happening.
I've set-up a second image pipeline but it doesn't change the image in any way, even though it becomes very slow and something is happening.
- Sun Feb 03, 2019 11:04 am
- Forum: Development
- Topic: OpenImageDenoise
- Replies: 313
- Views: 157699
Re: OpenImageDenoise
I've added the initial support for the library but couldn't test since LuxcoreUI was refusing to load any test scene, being unable to parse the PLY files included. [LuxCore][254.269] /home/daniel/Documents/lux2/LinuxCompile/LuxCore/scenes/simple [SDL][254.269] Reading scene: ./simple.scn [SDL][254....