Linux Mint 18.3 (Ubuntu 16.04)acasta69 wrote: ↑Thu Jan 31, 2019 1:01 pmBy the way: which platform are you working on?alpistinho wrote: ↑Thu Jan 31, 2019 11:57 am Maybe that's better than what I am doing. I think this library uses Intel MKL, so that would be another dependency. I will try to compile against the binary later today when I am home.
OpenImageDenoise
- alpistinho
- Developer
- Posts: 198
- Joined: Thu Jul 05, 2018 11:38 pm
- Location: Rio de Janeiro
Re: OpenImageDenoise
Re: OpenImageDenoise
Like with Intel Embree, we can just use their binaries. I usually include the sources of small libraries without binaries available for Windows, Linux and MacOS.
I can add the support for albedo AOV tomorrow ... today I was skiing
I can add the support for albedo AOV tomorrow ... today I was skiing
Re: OpenImageDenoise
oh, that's one less problem to worry about then
- alpistinho
- Developer
- Posts: 198
- Joined: Thu Jul 05, 2018 11:38 pm
- Location: Rio de Janeiro
Re: OpenImageDenoise
Just an update: Both Embree and OIDN include a copy of libtbbmalloc.so.2, but they are not the same. They're probably compiled against different versions of TBB.
I need now to find a way to include both and link everything correctly
I need now to find a way to include both and link everything correctly
Re: OpenImageDenoise
The newest is likely to work fine for bothalpistinho wrote: ↑Thu Jan 31, 2019 9:58 pm Just an update: Both Embree and OIDN include a copy of libtbbmalloc.so.2, but they are not the same. They're probably compiled against different versions of TBB.
I need now to find a way to include both and link everything correctly
P.S. just try one, than the other ... it may/should work.
- alpistinho
- Developer
- Posts: 198
- Joined: Thu Jul 05, 2018 11:38 pm
- Location: Rio de Janeiro
Re: OpenImageDenoise
I've tried to compile OIDN following their instructions but it is not working either. I don't know if something is messed up with my system.
I will try to compile against the binary and use the same shared library for both. Sorry for my rusty building abilities
I will try to compile against the binary and use the same shared library for both. Sorry for my rusty building abilities
Code: Select all
daniel@daniel-desktop ~/Documents/oidn/build $ make
[ 1%] Building CXX object common/CMakeFiles/common.dir/tasking.cpp.o
/home/daniel/Documents/oidn/common/tasking.cpp:45:34: error: no member named 'this_task_arena' in namespace 'tbb'; did you mean 'task_arena'?
const int threadIndex = tbb::this_task_arena::current_thread_index();
~~~~~^~~~~~~~~~~~~~~
task_arena
/usr/include/tbb/task_arena.h:264:19: note: 'task_arena' declared here
using interface7::task_arena;
^
/home/daniel/Documents/oidn/common/tasking.cpp:51:34: error: no member named 'this_task_arena' in namespace 'tbb'; did you mean 'task_arena'?
const int threadIndex = tbb::this_task_arena::current_thread_index();
~~~~~^~~~~~~~~~~~~~~
task_arena
/usr/include/tbb/task_arena.h:264:19: note: 'task_arena' declared here
using interface7::task_arena;
Re: OpenImageDenoise
So, just as nvidia's denoiser. It is absolutely blind to bidir noise.
However, I wonder since it's open source if someone could create and train dataset for bidir as well? Maybe like a mode switch of the denoiser that's autoselected depending on selected renderer(bidir/path-oclpath)?
I don't care about bidir at all, but maybe for future development, to get rid of that... thing completely.
However, I wonder since it's open source if someone could create and train dataset for bidir as well? Maybe like a mode switch of the denoiser that's autoselected depending on selected renderer(bidir/path-oclpath)?
I don't care about bidir at all, but maybe for future development, to get rid of that... thing completely.
Re: OpenImageDenoise
I added the support for Albedo AOV to all CPU path tracers. This rendering:
Has this Albedo AOV:
Next OpenCL and BiDir support.
Re: OpenImageDenoise
Looks good to me, have to test with oidn...
But... you said cpu pathtracers, ocl won't output this aov?
But... you said cpu pathtracers, ocl won't output this aov?
Re: OpenImageDenoise
Not yet, I have still to write the OpenCL and BiDir support.