Far end of shadow noise

Use this forum for general user support and related questions.
Forum rules
Please upload a testscene that allows developers to reproduce the problem, and attach some images.
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Far end of shadow noise

Post by lacilaci »

This might be normal behavior but if there is an object currently in a far end of shadow of an object, that area won't get denoised. Not sure if noise samples are too far inbetween or there is a correlation but denoiser won't do anything with those areas unless they are very low in noise.

In my test example I needed over 2500 samples for the area to get properly denoised and it's still kinda not perfect.

10samples
10_samples.jpg
10samples denoised
10_samples_denoised.jpg
50samples
50_samples.jpg
50samples denoised
50_samples_denoised.jpg
500samples
500_samples.jpg
500samples denoised
500_samples_denoised.jpg
scene:
noise_denoise_shadow.blend
(980.46 KiB) Downloaded 134 times
Is this normal? Or maybe oidn related issue?
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Far end of shadow noise

Post by Dade »

That is quite strange, are you using "tiled denoising" ? It may be a bug introduced with that patch, I will check.
Support LuxCoreRender project with salts and bounties
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: Far end of shadow noise

Post by lacilaci »

nope, this is normal denoising. I haven't even seen tiled denoising in blender actually
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Far end of shadow noise

Post by Dade »

I can reproduce the problem but I can not see any error on our side.

I will upgrade the binaries to the latest Oidn version than, if the problem is still there, I will report behavior to Intel.
Support LuxCoreRender project with salts and bounties
User avatar
lacilaci
Donor
Donor
Posts: 1969
Joined: Fri May 04, 2018 5:16 am

Re: Far end of shadow noise

Post by lacilaci »

Dade wrote: Thu May 30, 2019 7:37 am I can reproduce the problem but I can not see any error on our side.

I will upgrade the binaries to the latest Oidn version than, if the problem is still there, I will report behavior to Intel.
Good, by the way, this can also happen in a more complex environment.. It always kinda seems related to very soft shadow. I assumed that maybe there is some pattern that oidn recognizes in that part.
wasd
Posts: 319
Joined: Tue Apr 24, 2018 7:20 pm

Re: Far end of shadow noise

Post by wasd »

lacilaci wrote: Wed May 29, 2019 8:57 am denoiser won't do anything with those areas unless they are very low in noise.
I've got similar behaviour in this scene download/file.php?id=4471.
It's Glossy Translucent mixed with Null, with homogeneous multiscattering volume.
CPU Bidir + Metropolis | Core i5-4570
CodeHD
Donor
Donor
Posts: 437
Joined: Tue Dec 11, 2018 12:38 pm
Location: Germany

Re: Far end of shadow noise

Post by CodeHD »

I did expereince some issues as well (though not this one) when there were completely black background areas in my image.
Have you tried computing albedo and average shading normal AOVs as well? I had the feeling that helped the algorithm.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Far end of shadow noise

Post by B.Y.O.B. »

CodeHD wrote: Thu May 30, 2019 2:20 pm Have you tried computing albedo and average shading normal AOVs as well? I had the feeling that helped the algorithm.
They are always enabled in BlendLuxCore if the denoiser is used.
CodeHD
Donor
Donor
Posts: 437
Joined: Tue Dec 11, 2018 12:38 pm
Location: Germany

Re: Far end of shadow noise

Post by CodeHD »

B.Y.O.B. wrote: Thu May 30, 2019 2:28 pm They are always enabled in BlendLuxCore if the denoiser is used.
Hmm ok, it seems I was just wrong with that feeling.

I just tried that scene I had in mind again (indeed no difference when including albedo + nromal aov), and it seems to depend also on where I focus in that case, with the result failing completely when my object is defocused (which unfortunately is the scientifically correct case for that instrument :D ):

focused case (works):
foc_render.png
foc_denoise.png
defocused case (doesn't work):
defoc_render.png
defoc_denoise.png
kintuX
Posts: 809
Joined: Wed Jan 10, 2018 2:37 am

Re: Far end of shadow noise

Post by kintuX »

I think it's OIDN 'failing' to achieve human anticipations... did observed similar issues on occasions & also with NVidia's denoiser... more so, all over noticing critiques about this tech. Human adapted, tolerance raised...

And a reminder, during NVidias first AI filtering/denoising demo it was noted that this tools are meant for better, faster, more efficient previewing!!! not final HQ renders. ;)
Post Reply