OpenImageDenoise

Discussion related to the Engine functionality, implementations and API.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 2505
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: OpenImageDenoise

Post by B.Y.O.B. » Fri Feb 15, 2019 12:29 pm

S0rda wrote:
Fri Feb 15, 2019 12:23 pm
Are there any settings for OIDN? To be able to adjust the radii and stuff, as in the usual bvd denoiser?
Not really.
The options available to developers are listed in this table: https://github.com/OpenImageDenoise/oidn#rt
But as end-user, you always want these settings:
- normal and albedo AOVs as additional input
- HDR mode on
- sRGB mode off
So these settings are not exposed in the UI, because changing them would only make the result worse.
Support LuxCoreRender project with salts and bounties

sanjinms
Posts: 23
Joined: Tue Jun 26, 2018 6:58 pm

Re: OpenImageDenoise

Post by sanjinms » Sat Feb 16, 2019 11:29 am

Some parts of transparent materials (arch glass in this case) are still noisy after OIDN pass?
Attachments
bsp_IMAGE-OIDN.png
Image + OIDN
bsp_ALBEDO.png
Albedo pass

User avatar
lacilaci
Donor
Donor
Posts: 990
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci » Sat Feb 16, 2019 11:52 am

sanjinms wrote:
Sat Feb 16, 2019 11:29 am
Some parts of transparent materials (arch glass in this case) are still noisy after OIDN pass?
Do you by any chance use metropolis sampler? I've noticed that metropolis takes quite some time for clean albedo and normal aov's.

sanjinms
Posts: 23
Joined: Tue Jun 26, 2018 6:58 pm

Re: OpenImageDenoise

Post by sanjinms » Sat Feb 16, 2019 1:11 pm

lacilaci wrote:
Sat Feb 16, 2019 11:52 am
sanjinms wrote:
Sat Feb 16, 2019 11:29 am
Some parts of transparent materials (arch glass in this case) are still noisy after OIDN pass?
Do you by any chance use metropolis sampler? I've noticed that metropolis takes quite some time for clean albedo and normal aov's.
I will try Metropolis!

User avatar
lacilaci
Donor
Donor
Posts: 990
Joined: Fri May 04, 2018 5:16 am

Re: OpenImageDenoise

Post by lacilaci » Sat Feb 16, 2019 1:13 pm

sanjinms wrote:
Sat Feb 16, 2019 1:11 pm
lacilaci wrote:
Sat Feb 16, 2019 11:52 am
sanjinms wrote:
Sat Feb 16, 2019 11:29 am
Some parts of transparent materials (arch glass in this case) are still noisy after OIDN pass?
Do you by any chance use metropolis sampler? I've noticed that metropolis takes quite some time for clean albedo and normal aov's.
I will try Metropolis!
No, I was suggesting exact opposite. Don't use metropolis.

sanjinms
Posts: 23
Joined: Tue Jun 26, 2018 6:58 pm

Re: OpenImageDenoise

Post by sanjinms » Sat Feb 16, 2019 1:19 pm

lacilaci wrote:
Sat Feb 16, 2019 1:13 pm
sanjinms wrote:
Sat Feb 16, 2019 1:11 pm
lacilaci wrote:
Sat Feb 16, 2019 11:52 am


Do you by any chance use metropolis sampler? I've noticed that metropolis takes quite some time for clean albedo and normal aov's.
I will try Metropolis!
No, I was suggesting exact opposite. Don't use metropolis.
Ohh sorry.... I Didn't use metropolis....

sanjinms
Posts: 23
Joined: Tue Jun 26, 2018 6:58 pm

Re: OpenImageDenoise

Post by sanjinms » Sat Feb 16, 2019 1:22 pm

sanjinms wrote:
Sat Feb 16, 2019 1:19 pm
lacilaci wrote:
Sat Feb 16, 2019 1:13 pm
sanjinms wrote:
Sat Feb 16, 2019 1:11 pm


I will try Metropolis!
No, I was suggesting exact opposite. Don't use metropolis.
Ohh sorry.... I Didn't use metropolis....
I got same effect on exterior scene.
Attachments
Ext.jpg

sanjinms
Posts: 23
Joined: Tue Jun 26, 2018 6:58 pm

Re: OpenImageDenoise

Post by sanjinms » Sat Feb 16, 2019 1:33 pm

sanjinms wrote:
Sat Feb 16, 2019 1:22 pm
sanjinms wrote:
Sat Feb 16, 2019 1:19 pm
lacilaci wrote:
Sat Feb 16, 2019 1:13 pm


No, I was suggesting exact opposite. Don't use metropolis.
Ohh sorry.... I Didn't use metropolis....
I got same effect on exterior scene.
However, blendluxcore and oidn are awesome :roll:

User avatar
B.Y.O.B.
Developer
Developer
Posts: 2505
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: OpenImageDenoise

Post by B.Y.O.B. » Sat Feb 16, 2019 1:50 pm

Yes, noise in the albedo AOV essentially disables the denoiser in those areas.
Let's see if noise-free reflection/refraction in 1 sample can be implemented in LuxCore (I asked here). If not, it might be a good idea to drop the reflection entirely (in the albedo AOV) or prefer reflection/refraction based on IOR.

By the way guys, could you stop doing full quotes so often? It makes the thread harder to read.
Support LuxCoreRender project with salts and bounties

sanjinms
Posts: 23
Joined: Tue Jun 26, 2018 6:58 pm

Re: OpenImageDenoise

Post by sanjinms » Sat Feb 16, 2019 3:36 pm

B.Y.O.B. wrote:
Sat Feb 16, 2019 1:50 pm
Yes, noise in the albedo AOV essentially disables the denoiser in those areas.
Let's see if noise-free reflection/refraction in 1 sample can be implemented in LuxCore (I asked here). If not, it might be a good idea to drop the reflection entirely (in the albedo AOV) or prefer reflection/refraction based on IOR.

By the way guys, could you stop doing full quotes so often? It makes the thread harder to read.
Sorry for full quotes, it's my fault.

Post Reply