DLSC Explained

Discussion related to the Engine functionality, implementations and API.
marcatore
Posts: 284
Joined: Wed Jan 10, 2018 8:04 am

Re: DLCS Explained

Post by marcatore » Thu Oct 25, 2018 6:50 am

B.Y.O.B. wrote:
Wed Oct 24, 2018 2:38 pm
Sharlybg wrote:
Wed Oct 24, 2018 11:19 am
Cache entry radius : The bigger the scene the bigger the number
Could we automatically compute this? (Maybe from scene bounding box)
If yes, we could show a multiplier to the user for those cases where the auto-computed value has to be adjusted.
I think that some tooltips and a remark on the documentation could be a good start helping users understanding how to setup the renderer.
I prefer documented freedom instead hardcoded tricks... or a button that switch from the automatic mode to an "advanced" one where you have all the options visible.

User avatar
B.Y.O.B.
Developer
Developer
Posts: 2809
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: DLCS Explained

Post by B.Y.O.B. » Thu Oct 25, 2018 8:39 am

I could use some help with the descriptions for the following parameters:
https://github.com/LuxCoreRender/BlendL ... ig.py#L146

- entry normal angle
- entry max. passes
- entry convergence threshold
- light threshold
- target cache hit ratio
- max. depth
- max. samples count
Support LuxCoreRender project with salts and bounties

kintuX
Posts: 434
Joined: Wed Jan 10, 2018 2:37 am

Re: DLCS Explained

Post by kintuX » Thu Oct 25, 2018 8:09 pm

Are there any specific papers which were used as a basis?

Did the fast run again... (a short overview):

Since i know appleseed 1.7 has (had?) Light Tree sampler (WIP) ~ similar to DLSC, i Started with Petra's GSoC 2017 with AppleseedHQ which lead me to Efficient sampling of many lights (@ompf2.com). I then also checked the psychopath renderer... nothing here :|

So i headed back to Dade's original thread & then read the vray adaptive lights... did took a look at few test threads here and here... also, did some myself...

and now i'm like 'overwhelmed' :roll: :? ... got to grok for some time - let thoughts settle down, sink in... but i also need a confirmation... i have to feel clear-minded of all the complexities to 'explain it in simple terms.' ;)

:lol: ain't easy to follow R&D in CGI field
:oops: loosing it a bit

- Am i tracing the right path?

User avatar
Dade
Developer
Developer
Posts: 2819
Joined: Mon Dec 04, 2017 8:36 pm

Re: DLCS Explained

Post by Dade » Thu Oct 25, 2018 9:42 pm

kintuX wrote:
Thu Oct 25, 2018 8:09 pm
Are there any specific papers which were used as a basis?
Nope, it is original work.
kintuX wrote:
Thu Oct 25, 2018 8:09 pm
read the vray adaptive lights
It is loosely inspired by this but they are (probably) using the photon map to extract the data while I have to build everything from scratch for obvious reasons (I don't have a photon map).
Support LuxCoreRender project with salts and bounties

kintuX
Posts: 434
Joined: Wed Jan 10, 2018 2:37 am

Re: DLCS Explained

Post by kintuX » Sat Oct 27, 2018 12:04 pm

Dade wrote:
Thu Oct 25, 2018 9:42 pm
kintuX wrote:
Thu Oct 25, 2018 8:09 pm
Are there any specific papers which were used as a basis?
Nope, it is original work.
kintuX wrote:
Thu Oct 25, 2018 8:09 pm
read the vray adaptive lights
It is loosely inspired by this but they are (probably) using the photon map to extract the data while I have to build everything from scratch for obvious reasons (I don't have a photon map).
Wow, respect for the work done and thank you for this 'photon VS RT' info, totally missed that... 8-)

I assume then, since you followed the principle, behavior is the same?
(It feels pretty much so)

User avatar
Dade
Developer
Developer
Posts: 2819
Joined: Mon Dec 04, 2017 8:36 pm

Re: DLCS Explained

Post by Dade » Sat Oct 27, 2018 2:30 pm

kintuX wrote:
Sat Oct 27, 2018 12:04 pm
I assume then, since you followed the principle, behavior is the same?
(It feels pretty much so)
I guess yes ... but I don't have the V-Ray sources so I'm not sure :mrgreen:
Support LuxCoreRender project with salts and bounties

User avatar
Sharlybg
Donor
Donor
Posts: 1441
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: DLSC Explained

Post by Sharlybg » Sun Dec 02, 2018 9:33 pm

This one seem to be a hard scenario case for DLSC. Don't know wich settings will fix theses artifact. I only play with warmup samples and entry radius. Fom my perspective DLSC should be simply avoid in case of heavy indirect lit 3D scene. But i'm curious to see wich settings could work for this one :

i use last BETA 3.

Ref Log power render :
D logp.jpg
Resulting DLSC :
D DLSC.jpg

Blend file:
DLSC.blend
(633.18 KiB) Downloaded 48 times
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA

User avatar
Dade
Developer
Developer
Posts: 2819
Joined: Mon Dec 04, 2017 8:36 pm

Re: DLSC Explained

Post by Dade » Mon Dec 03, 2018 8:33 am

Sharlybg wrote:
Sun Dec 02, 2018 9:33 pm
This one seem to be a hard scenario case for DLSC. Don't know wich settings will fix theses artifact. I only play with warmup samples and entry radius. Fom my perspective DLSC should be simply avoid in case of heavy indirect lit 3D scene. But i'm curious to see wich settings could work for this one :
Do I have to change something in the attached scene ? If I run the scene as it is, it seems to work fine in LuxCoreUI:

dlsc1.jpg

and Blender:

dlsc2.jpg
Support LuxCoreRender project with salts and bounties

User avatar
Sharlybg
Donor
Donor
Posts: 1441
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: DLSC Explained

Post by Sharlybg » Mon Dec 03, 2018 10:27 am

You have to let it run an hour or more to see artifact. Anyway yesterday on my home rig artifact were more strong easy to spot. And today after updating on the firm rig i've to render for an hour to easily spot every splotches. But i remenber i had done the update before doing test yesterday .... :roll: will try when back home.

here the result one hour :
DLSC.jpg

artifact underlined:
DLSC 1.jpg
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA

User avatar
Sharlybg
Donor
Donor
Posts: 1441
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: DLSC Explained

Post by Sharlybg » Mon Dec 03, 2018 11:54 am

And here is the same with higher settings : see the splotches up left.

Entry radius = 15cm
Warmup samples = 4096
DLSC 15cm + 4096.jpg
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA

Post Reply