Optix denoiser imagepipeline plugin

Discussion related to the LuxCore functionality, implementations and API.
User avatar
B.Y.O.B.
Developer
Posts: 3681
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Optix denoiser imagepipeline plugin

Post by B.Y.O.B. » Thu Jul 30, 2020 9:11 pm

The Optix denoiser is not used in the addon yet.

User avatar
B.Y.O.B.
Developer
Posts: 3681
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Optix denoiser imagepipeline plugin

Post by B.Y.O.B. » Fri Jul 31, 2020 12:36 pm

@Dade, do you think it would make sense to add a "minimum samples per pixel" parameter to the denoiser imagepipeline plugins? Where the plugin would do nothing until the spp are above the minimum threshold.
It would be easier than checking the Samples/pixel in the addon and update the imagepipeline based on the results.

The reason is that OptiX returns an image with big black squares when there aren't enough samples, and this leads to heavy flickering when moving the camera around.

User avatar
Dade
Developer
Posts: 4498
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Optix denoiser imagepipeline plugin

Post by Dade » Fri Jul 31, 2020 1:05 pm

B.Y.O.B. wrote:
Fri Jul 31, 2020 12:36 pm
@Dade, do you think it would make sense to add a "minimum samples per pixel" parameter to the denoiser imagepipeline plugins? Where the plugin would do nothing until the spp are above the minimum threshold.
It would be easier than checking the Samples/pixel in the addon and update the imagepipeline based on the results.

The reason is that OptiX returns an image with big black squares when there aren't enough samples, and this leads to heavy flickering when moving the camera around.
I noticed this problem happens only if you use the ALBEDO+NORMAL AOVs (new feature, supported only by Optix v7.1) so a possible solution would be to use only ALBEDO AOV (supported also by Optix v7.0) for preview. It is a bit strange as behavior and, at first, I have classified it as a possible beta driver bug.

The alternative would be to wait a bit of samples/pixel, as you wrote, however it isn't very clear where the threshold should be and you may still end with some black tile.
In this case, you can define 2 pipelines, one without Optix and one with and than use the first one for few samples/pixel and switch to the second one after. So you will not have to do any scene edit (probably causing a restart of the render).
Support LuxCoreRender project with salts and bounties

User avatar
B.Y.O.B.
Developer
Posts: 3681
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Optix denoiser imagepipeline plugin

Post by B.Y.O.B. » Fri Jul 31, 2020 1:44 pm

Dade wrote:
Fri Jul 31, 2020 1:05 pm
The alternative would be to wait a bit of samples/pixel, as you wrote, however it isn't very clear where the threshold should be and you may still end with some black tile.
In this case, you can define 2 pipelines, one without Optix and one with and than use the first one for few samples/pixel and switch to the second one after. So you will not have to do any scene edit (probably causing a restart of the render).
Editing the imagepipeline would not cause a scene edit either.

Anyway, I would make this feature user-configurable, because some might prefer a bit of noise during the first x samples rather than a completeyl smudgy image, even if the black tiles thing is a bug that is eventually fixed.
From a programming perspective, I think it would be much easier to do this check in the imagepipeline plugin than in the Blender addon, so if you are OK with this, I would add it there.

User avatar
Dade
Developer
Posts: 4498
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Optix denoiser imagepipeline plugin

Post by Dade » Fri Jul 31, 2020 2:16 pm

B.Y.O.B. wrote:
Fri Jul 31, 2020 1:44 pm
From a programming perspective, I think it would be much easier to do this check in the imagepipeline plugin than in the Blender addon, so if you are OK with this, I would add it there.
It should be easy to add as an additional plugin option.
Support LuxCoreRender project with salts and bounties

User avatar
Sharlybg
Donor
Posts: 2152
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: Optix denoiser imagepipeline plugin

Post by Sharlybg » Fri Jul 31, 2020 2:34 pm

Are we going to have this same behaviour a the end :?: : https://youtu.be/oYjrnsKzApM?t=28
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA

User avatar
B.Y.O.B.
Developer
Posts: 3681
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Optix denoiser imagepipeline plugin

Post by B.Y.O.B. » Fri Jul 31, 2020 2:39 pm

Yes, pretty much.

User avatar
Sharlybg
Donor
Posts: 2152
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: Optix denoiser imagepipeline plugin

Post by Sharlybg » Fri Jul 31, 2020 3:24 pm

B.Y.O.B. wrote:
Fri Jul 31, 2020 2:39 pm
Yes, pretty much.
Top :geek:
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA

User avatar
Odilkhan Yakubov
Posts: 115
Joined: Fri Jan 26, 2018 10:07 pm
Location: Tashkent, Uzbekistan

Re: Optix denoiser imagepipeline plugin

Post by Odilkhan Yakubov » Sat Aug 01, 2020 7:27 am

Is there has any release date on optixdenoiser?
Allah bless us!

CPU: Core 2 Quad Q6600 @2.4Ghz
GPU: MSI GTX 1060 6Gb GDDR5 192bit
RAM: 3Gb DDR2 800Mhz (too old :( )
OS: Win7 64bit
Blender: 2.90 alpha (E-Cycles version)
LuxCore: v2.4 (official)

juangea
Donor
Posts: 168
Joined: Thu Jan 02, 2020 6:23 pm

Re: Optix denoiser imagepipeline plugin

Post by juangea » Sat Aug 01, 2020 7:55 am

I dare to say... when it´s ready in alpha builds and the release date for 2.5 in general will be... when it´s ready :)

Now, regarding the availability in alpha builds, as soon as BYOB finishes it you will be able to test it, as always :)

Post Reply