Add option to not consider light tracing samples for batch.haltspp?

Discussion related to the LuxCore functionality, implementations and API.
Post Reply
User avatar
B.Y.O.B.
Developer
Posts: 3681
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Add option to not consider light tracing samples for batch.haltspp?

Post by B.Y.O.B. » Thu Jul 16, 2020 2:46 pm

Hi,

I think it would make sense to add an option to not consider samples from light tracing (hybrid backforward) when checking the haltspp condition.
In the Blender addon, I would enable this option if the "cache-friendly" or "out-of-core" sampling patterns are used. Currently it is impossible to set a sensible haltspp condition if these sampling patterns are used together with light tracing - for example, if the user selects out-of-core, sets it to do 1024 samples per pixel per pass, and then sets the halt samples to 1024, the result will be an image that is only rendered about halfway.

juangea
Donor
Posts: 168
Joined: Thu Jan 02, 2020 6:23 pm

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by juangea » Sun Jul 19, 2020 8:21 am

Couldn’t that lead to flickering in animation?

User avatar
Dade
Developer
Posts: 4498
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by Dade » Sun Jul 19, 2020 9:55 am

B.Y.O.B. wrote:
Thu Jul 16, 2020 2:46 pm
I think it would make sense to add an option to not consider samples from light tracing (hybrid backforward) when checking the haltspp condition.
In the Blender addon, I would enable this option if the "cache-friendly" or "out-of-core" sampling patterns are used. Currently it is impossible to set a sensible haltspp condition if these sampling patterns are used together with light tracing - for example, if the user selects out-of-core, sets it to do 1024 samples per pixel per pass, and then sets the halt samples to 1024, the result will be an image that is only rendered about halfway.
My idea is to add (in v2.5) the support for samples/pixel halt condition with 2 parameters:

- 1 parameters => works like now
- 2 parameters => one halt condition for eye tracing and one for light tracing. if a value is 0, it is ignored.

So you can set a eye+light tracing stop condition or a separate eye and/or light tracing condition. Pretty much all possible combination.
Support LuxCoreRender project with salts and bounties

Martini
Posts: 56
Joined: Fri Nov 23, 2018 11:36 am
Location: Australia

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by Martini » Sun Jul 19, 2020 12:16 pm

Dade wrote:
Sun Jul 19, 2020 9:55 am
My idea is to add (in v2.5) the support for samples/pixel halt condition with 2 parameters:

- 1 parameters => works like now
- 2 parameters => one halt condition for eye tracing and one for light tracing. if a value is 0, it is ignored.

So you can set a eye+light tracing stop condition or a separate eye and/or light tracing condition. Pretty much all possible combination.
Sounds good! I am waiting for this also :D

I am hoping that once one of the stop conditions is met, it will only terminate that render engine, and let the other one continue until it also hits its own stop condition?
i9 9900K @ 5000MHz | 2x Gigabyte AORUS RTX 2080 Ti Extreme Waterforce WB 11G @ 2010MHz
Z390 Aorus Pro | 32GB Kingston HyperX Predator RGB @ 4300MHz

User avatar
Dade
Developer
Posts: 4498
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by Dade » Sun Jul 19, 2020 1:03 pm

Martini wrote:
Sun Jul 19, 2020 12:16 pm
I am hoping that once one of the stop conditions is met, it will only terminate that render engine, and let the other one continue until it also hits its own stop condition?
No, it will continue until both are met but the result is pretty match the same.
Support LuxCoreRender project with salts and bounties

Martini
Posts: 56
Joined: Fri Nov 23, 2018 11:36 am
Location: Australia

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by Martini » Sun Jul 19, 2020 1:13 pm

Dade wrote:
Sun Jul 19, 2020 1:03 pm
No, it will continue until both are met but the result is pretty match the same.
OK, I can live with that ;)
i9 9900K @ 5000MHz | 2x Gigabyte AORUS RTX 2080 Ti Extreme Waterforce WB 11G @ 2010MHz
Z390 Aorus Pro | 32GB Kingston HyperX Predator RGB @ 4300MHz

juangea
Donor
Posts: 168
Joined: Thu Jan 02, 2020 6:23 pm

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by juangea » Sun Jul 19, 2020 1:16 pm

I think that he means that if Eye rays are put to 512 samples and Light tracing is put at 128 samples, light racing will stop rendering so every frame inside an animation will have 512 eye samples and 128 light tracing samples, theoretically avoiding flickering between frames :)

Martini
Posts: 56
Joined: Fri Nov 23, 2018 11:36 am
Location: Australia

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by Martini » Sun Jul 19, 2020 6:31 pm

juangea wrote:
Sun Jul 19, 2020 1:16 pm
I think that he means that if Eye rays are put to 512 samples and Light tracing is put at 128 samples, light racing will stop rendering so every frame inside an animation will have 512 eye samples and 128 light tracing samples, theoretically avoiding flickering between frames :)
Yes, you are right.

But ideally we will also eventually get an option to manually specify the average luminance (in the same way that we can specify the clamping value) and then that may become a thing of the past :D
i9 9900K @ 5000MHz | 2x Gigabyte AORUS RTX 2080 Ti Extreme Waterforce WB 11G @ 2010MHz
Z390 Aorus Pro | 32GB Kingston HyperX Predator RGB @ 4300MHz

User avatar
B.Y.O.B.
Developer
Posts: 3681
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by B.Y.O.B. » Tue Jul 21, 2020 11:43 am

Dade wrote:
Sun Jul 19, 2020 9:55 am
My idea is to add (in v2.5) the support for samples/pixel halt condition with 2 parameters:

- 1 parameters => works like now
- 2 parameters => one halt condition for eye tracing and one for light tracing. if a value is 0, it is ignored.

So you can set a eye+light tracing stop condition or a separate eye and/or light tracing condition. Pretty much all possible combination.
Sounds good.

User avatar
Dade
Developer
Posts: 4498
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Add option to not consider light tracing samples for batch.haltspp?

Post by Dade » Wed Jul 22, 2020 10:44 am

v2.5 has now the support for 1 or 2 parameters as described in my previous post.
Support LuxCoreRender project with salts and bounties

Post Reply