Page 4 of 7
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 10:55 am
by Dade
Dade wrote: ↑Thu May 28, 2020 9:43 pm
acasta69 wrote: ↑Thu May 28, 2020 7:27 pm
Defining LUXRAYS_DISABLE_CUDA and LUXRAYS_DISABLE_OPENCL seems to have no effect: LuxCoreUI still allows to choose OCL render engines. I'll try to check why this happens.
Yes but it should have no device available at all for the rendering. I guess it could be removed from the menu too.
I updated LuxCoreUI to show OpenCL/CUDA related options only if OpenCL/CUDA is available at runtime.
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 11:17 am
by u3dreal
In process of updating deps and azure files .... seems luxcore only needs libcuda.dylib and libnvrtc.dylib ...
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 12:35 pm
by u3dreal
Done
No access to secure file for me .. should i merge ? otherwise no check possible. maybe you can check ..
https://github.com/LuxCoreRender/LuxCore/pull/381
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 12:36 pm
by Dade
u3dreal wrote: ↑Fri May 29, 2020 11:17 am
In process of updating deps and azure files .... seems luxcore only needs libcuda.dylib and libnvrtc.dylib ...
Don't you need only libnvrtc.dylib ? Isn't libcuda.dylib already installed on the system by the driver ?
P.S. don't forget also the nvrtc-builtin DLL too.
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 12:47 pm
by u3dreal
Dade wrote: ↑Fri May 29, 2020 12:36 pm
Don't you need only libnvrtc.dylib ? Isn't libcuda.dylib already installed on the system by the driver ?
Will have to check ..
Dade wrote: ↑Fri May 29, 2020 12:36 pm
P.S. don't forget also the nvrtc-builtin DLL too.
OK which one is needed ?? libnvrtc-buildins.dylib or libnvrtc-buildins.10.1.dylib
Are you sure ??? if so i will have to add the path for libnvrtc-buildins also somewhere in the code ..
I checked with otool ... libtool for osx ... libcuda or libnvrtc do not depend on libnvrtc-buildins .. ?
I think libcuda is not included with the driver since it is in Developer folder ... which does not get created when installing just the driver
when could i notice that buildins is missing ?
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 1:56 pm
by Dade
It is explained here:
viewtopic.php?f=5&t=2201&start=20#p23231
You need to see both:
Code: Select all
CUDA support: enabled
CUDA support: available
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 2:23 pm
by u3dreal
Dade wrote: ↑Fri May 29, 2020 1:56 pm
Code: Select all
CUDA support: enabled
CUDA support: available
Ok then everything is fine now. I will commit.
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 3:00 pm
by u3dreal
Wow new azure record 36min
So cool we just have to compile once .. all seems fine will test when linux and windows finished.
We should also update this
Code: Select all
[ 88%] [BISON][lux_parser] Building parser with bison 3.6.2
/Users/runner/runners/2.168.2/work/1/s/src/luxcore/luxparser/luxparse.y:20.1-35: warning: deprecated directive: ‘%name-prefix "luxcore_parserlxs_yy"’, use ‘%define api.prefix {luxcore_parserlxs_yy}’ [-Wdeprecated]
20 | %name-prefix "luxcore_parserlxs_yy"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| %define api.prefix {luxcore_parserlxs_yy}
i use bison 3.6 now .. so it should be no problem on my side
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 4:05 pm
by acasta69
Dade wrote: ↑Fri May 29, 2020 10:55 am
Dade wrote: ↑Thu May 28, 2020 9:43 pm
acasta69 wrote: ↑Thu May 28, 2020 7:27 pm
Defining LUXRAYS_DISABLE_CUDA and LUXRAYS_DISABLE_OPENCL seems to have no effect: LuxCoreUI still allows to choose OCL render engines. I'll try to check why this happens.
Yes but it should have no device available at all for the rendering. I guess it could be removed from the menu too.
I updated LuxCoreUI to show OpenCL/CUDA related options only if OpenCL/CUDA is available at runtime.
The GPU devices are actually available, I think the two definitions are not passed on from cmake to the build stage:
Code: Select all
CMake Warning:
Manually-specified variables were not used by the project:
LUXRAYS_DISABLE_CUDA
LUXRAYS_DISABLE_OPENCL
Not a big problem in any case, I think.
Re: Unified executable (for CPU-only, OpenCL and CUDA)
Posted: Fri May 29, 2020 4:10 pm
by acasta69
I have updated the azure pipeline files for Windows and it's running now. I'll check the binaries as soon as they are available.
About Linux: is it enough to build only the version with neither "opencl" nor "cuda" in the directory name?
Or do you need to modify the build scripts in the "LinuxCompile" repo?