PhotonGI caustic cache re-factoring

Discussion related to the Engine functionality, implementations and API.
User avatar
lacilaci
Donor
Donor
Posts: 1637
Joined: Fri May 04, 2018 5:16 am

Re: PhotonGI caustic cache re-factoring

Post by lacilaci » Fri Nov 01, 2019 12:21 pm

epilectrolytics wrote:
Fri Nov 01, 2019 12:19 pm
lacilaci wrote:
Fri Nov 01, 2019 12:14 pm
What is samples per step?
That's the cache update period (path sample count between updates).
well then the "cache update period" or something like "compute each (#pass)" name could be a bit better maybe. But I don't know.

User avatar
epilectrolytics
Donor
Donor
Posts: 578
Joined: Thu Oct 04, 2018 6:06 am

PGI indirect + caustic incompatibility

Post by epilectrolytics » Sun Nov 03, 2019 4:44 pm

I'm trying to use indirect together with caustic (Hybrid+SDS) cache but it won't work.
When both are activated, no indirect cache is written and the render looks like direct light only.
Screenshot.jpg
Now it is possible to disable caustic cache, render and save persistent indirect cache and then activate caustic cache again and render from saved cache file.
This works for indirect light but the caustics are not updated any more as if persistent indirect cache somehow prohibits caustic cache update.

Are those caches properly decoupled in the persistent file?
I remember that in the original version they were stored together.
Now with vertex merging there is no reason to store a caustic cache file any more so it should be excluded from the persistent file and be generated during rendering independently.
Attachments
concreteC.blend.zip
(271.53 KiB) Downloaded 6 times
MBPro 15" 16GB i7-4850HQ GT750M, MacOS 10.13.6 & Win10Pro PC 16GB Ryzen 2700X, 2 x RTX 2070

User avatar
Dade
Developer
Developer
Posts: 3270
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: PGI indirect + caustic incompatibility

Post by Dade » Mon Nov 04, 2019 9:45 am

epilectrolytics wrote:
Sun Nov 03, 2019 4:44 pm
I'm trying to use indirect together with caustic (Hybrid+SDS) cache but it won't work.
When both are activated, no indirect cache is written and the render looks like direct light only.
I should have fixed this problem.
epilectrolytics wrote:
Sun Nov 03, 2019 4:44 pm
This works for indirect light but the caustics are not updated any more as if persistent indirect cache somehow prohibits caustic cache update.
I should have fixed this problem too (the update parameter wasn't saved).
Support LuxCoreRender project with salts and bounties

User avatar
epilectrolytics
Donor
Donor
Posts: 578
Joined: Thu Oct 04, 2018 6:06 am

Re: PGI indirect + caustic incompatibility

Post by epilectrolytics » Mon Nov 04, 2019 3:27 pm

Dade wrote:
Mon Nov 04, 2019 9:45 am
I should have fixed this problem too (the update parameter wasn't saved).
Yep, now everything works, thanks!

Only when reading from persistent file with different settings than it was written with (enabled/disabled caches) I get weird results but that is to be expected.
MBPro 15" 16GB i7-4850HQ GT750M, MacOS 10.13.6 & Win10Pro PC 16GB Ryzen 2700X, 2 x RTX 2070

User avatar
Dade
Developer
Developer
Posts: 3270
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: PGI indirect + caustic incompatibility

Post by Dade » Mon Nov 04, 2019 3:59 pm

epilectrolytics wrote:
Mon Nov 04, 2019 3:27 pm
Only when reading from persistent file with different settings than it was written with (enabled/disabled caches) I get weird results but that is to be expected.
Yes, you could literally use a cache file with a totally different scene and get some very very strange result but it is expected. It could be used for some mind blowing VFX but it would be a bit extreme :mrgreen:
Support LuxCoreRender project with salts and bounties

Post Reply