Page 9 of 13

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 1:21 pm
by Sharlybg
B.Y.O.B. wrote: Fri Jun 07, 2019 3:03 pm Yup, you need the 2.79 branch:
https://github.com/LuxCoreRender/BlendL ... aintenance
I've downloaded this file (by clicking on on download or clone) then unzip file on my addon folder. and i've downloaded https://github.com/LuxCoreRender/LuxCor ... tag/latest opencl 64.


And then copy all file in lastest luxcore in the bin folder of "BlendLuxCore-2.79_maintenance" in my blender addon folder. but nothing appear in the blender preference addon so i can enable or not.

Can someone with a windows Sys send me it own blendluxcore (with lastest source) folder zipped ?

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 1:33 pm
by B.Y.O.B.
Weird, your procedure sounds correct.
Did you restart Blender before you opened the user preferences?

Did you put it in the same addon folder as your existing BlendLuxCore folder?
Should be in %appdata%/local/roaming/blender foundation/2.79/scripts/addons (or so)

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 1:39 pm
by Sharlybg
B.Y.O.B. wrote: Mon Jun 10, 2019 1:33 pm Weird, your procedure sounds correct.
Did you restart Blender before you opened the user preferences?

Did you put it in the same addon folder as your existing BlendLuxCore folder?
Should be in %appdata%/local/roaming/blender foundation/2.79/scripts/addons (or so)
YES but this is it :
folder.jpg
Addon.jpg
And strangely the same procedure with blendluxcore- master (not maintenance) work as expected.

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 2:01 pm
by B.Y.O.B.
Try to rename the folder to something like "BlendLuxCore279", without special characters, maybe Blender doesn't like that.

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 2:05 pm
by Sharlybg
B.Y.O.B. wrote: Mon Jun 10, 2019 2:01 pm Try to rename the folder to something like "BlendLuxCore279", without special characters, maybe Blender doesn't like that.
You know what ?

you save me again ;)
luxc.jpg

Disney shader problem

Posted: Mon Jun 10, 2019 2:37 pm
by epilectrolytics
After successfully implementing the new Disney shader into several old projects, today it failed for the first time.
In the old classroom scene from the Lux master repo the Disney shader doesn't work with the chrome material for the metal parts.
Some parts appear normal, some have wrong roughness, some are black with some specularity and the rest is totally black.
When I switch back to the metal node everything renders correctly.
All other materials (except translucent lampshades) also have been ported to Disney but work fine.
:?:
The attachment Screenshot.jpg is no longer available
Screenshot.jpg

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 3:25 pm
by Dade
B.Y.O.B. wrote: Sat Jun 08, 2019 1:27 pm
Dade wrote: Sat Jun 08, 2019 1:15 pm I don't remember how it is supposed to work but it is likely to be a bug however try also to check another implementation like the Cycles one to see if the behavior matches or not.
In Cycles it looks the same on front and back faces.
Disney material is now double side.

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 3:44 pm
by B.Y.O.B.
epilectrolytics wrote: Mon Jun 10, 2019 2:37 pm After successfully implementing the new Disney shader into several old projects, today it failed for the first time.
In the old classroom scene from the Lux master repo the Disney shader doesn't work with the chrome material for the metal parts.
Some parts appear normal, some have wrong roughness, some are black with some specularity and the rest is totally black.
When I switch back to the metal node everything renders correctly.
Can you test again when the latest commit by Dade is built?
The black parts were caused by the single-sidedness of the shader (they have inverted normals).

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 3:52 pm
by epilectrolytics
Thanks for looking into it!
I just reloaded the scene and flipped the normals of the mesh but still renders black :?:

The latest commit is currently built on Azure and I will test when it is available.

Re: Disney BRDF material

Posted: Mon Jun 10, 2019 6:39 pm
by epilectrolytics
Dade wrote: Mon Jun 10, 2019 3:25 pm Disney material is now double side.
B.Y.O.B. wrote: Mon Jun 10, 2019 3:44 pm Can you test again when the latest commit by Dade is built?
Yep, it works (again)!

Thanks for the quick fix!

👍