Disney BRDF material

Discussion related to the Engine functionality, implementations and API.
User avatar
Dade
Developer
Developer
Posts: 2488
Joined: Mon Dec 04, 2017 8:36 pm

Disney BRDF material

Post by Dade » Wed May 29, 2019 4:05 pm

Stefan Bergmann has implemented Disney BRDF material from Siggraph 2012 paper in LuxCoreRender for his mater thesis and he was so kindly to donate the code back to the project.

The new material is now available on the main branch (for CPU rendering, OpenCL support will follow soon).

Some demo rendering from Stefan:

Clearcoat with rough metallic
Image

Cloth using Sheen
Image

Glossy
Image

Matte
Image

Mirror
Image

Subsurface approximation
Image
Support LuxCoreRender project with salts and bounties

provisory
Posts: 99
Joined: Wed Aug 01, 2018 4:26 pm

Re: Disney BRDF material

Post by provisory » Wed May 29, 2019 4:11 pm

Wow, fantastic news! Thank you Stefan!

provisory
Posts: 99
Joined: Wed Aug 01, 2018 4:26 pm

Re: Disney BRDF material

Post by provisory » Wed May 29, 2019 4:17 pm

Are there any limitations (e.g. does it work with BiDir)?

User avatar
lacilaci
Donor
Donor
Posts: 1093
Joined: Fri May 04, 2018 5:16 am

Re: Disney BRDF material

Post by lacilaci » Wed May 29, 2019 4:17 pm

Great news!

User avatar
epilectrolytics
Donor
Donor
Posts: 371
Joined: Thu Oct 04, 2018 6:06 am

Re: Disney BRDF material

Post by epilectrolytics » Wed May 29, 2019 4:26 pm

Awesome, big thanks!
MBPro 15" 16GB i7-4850HQ GT750M, MacOS 10.13.6 & Win10Pro PC 16GB Ryzen 2700X, RTX 2070, GTX 1060

User avatar
Sharlybg
Donor
Donor
Posts: 1325
Joined: Mon Dec 04, 2017 10:11 pm
Location: Ivory Coast

Re: Disney BRDF material

Post by Sharlybg » Wed May 29, 2019 4:41 pm

Don't understand what is going on. What is the bonus for having Disney BRDF material ?
how different it is from the current implementation ?

Is it more realistic ? faster to sample ?

We don't need principled shader now ?
Support LuxCoreRender project with salts and bounties

Portfolio : https://www.behance.net/DRAVIA

User avatar
epilectrolytics
Donor
Donor
Posts: 371
Joined: Thu Oct 04, 2018 6:06 am

Re: Disney BRDF material

Post by epilectrolytics » Wed May 29, 2019 5:06 pm

Disney = principled shader, see here.
It was not yet implemented in Luxcore but planned for v2.3.
It is more realistic but slower to sample because it has always a reflective component.
If fully implemented it should work similar to Cycles principled shader.
From what I see OCL code and Blender integration are still missing.
MBPro 15" 16GB i7-4850HQ GT750M, MacOS 10.13.6 & Win10Pro PC 16GB Ryzen 2700X, RTX 2070, GTX 1060

User avatar
lacilaci
Donor
Donor
Posts: 1093
Joined: Fri May 04, 2018 5:16 am

Re: Disney BRDF material

Post by lacilaci » Wed May 29, 2019 6:00 pm

is it brdf or bsdf if it has subsurface? I also wonder what is this approximated subsurfacing.

Do you plan to build future work on it? Adding translucency, thin film layer, will you turn this into a monster ubermaterial for 2.3? I hope it renders fast too...

provisory
Posts: 99
Joined: Wed Aug 01, 2018 4:26 pm

Re: Disney BRDF material

Post by provisory » Wed May 29, 2019 6:10 pm

If it works well, then it must make the switch between Cycles and LuxCore really easy, which would be a big step forward.

User avatar
Dade
Developer
Developer
Posts: 2488
Joined: Mon Dec 04, 2017 8:36 pm

Re: Disney BRDF material

Post by Dade » Wed May 29, 2019 6:26 pm

lacilaci wrote:
Wed May 29, 2019 6:00 pm
is it brdf or bsdf if it has subsurface? I also wonder what is this approximated subsurfacing.
It is a BRDF, no ray it is transmitted but it can include SSS look-like appearance.

You can just check the original paper if you want more details: https://disney-animation.s3.amazonaws.c ... tes_v2.pdf (you can skip the math/coding stuff and just look at picture at pag. 13)
Support LuxCoreRender project with salts and bounties

Post Reply