Adaptive sampling improvements

Discussion related to the Engine functionality, implementations and API.
User avatar
alpistinho
Developer
Developer
Posts: 168
Joined: Thu Jul 05, 2018 11:38 pm
Location: Rio de Janeiro

Re: Adaptive sampling improvements

Post by alpistinho » Fri Oct 25, 2019 2:42 pm

marcatore wrote:
Fri Oct 25, 2019 6:51 am
Sorry for the dumb question.
With this film pipeline, could we have the same color results between blender output and network rendering output?
At the moment, it seems that Blender applies something that changes colors and the output are different.

Could your develop solve this issue? Or am I completely wrong?
Blender applies its own color management after the render is finished.

I intend to fix that, but I need to use the OpenColorIO library and it has been complicated to do on Windows.

Once that is done, I will be able to create new film pipeline plugins that implements the same kind of color transformations that Blender does and then we'll be able to produce the same results anywhere
Support LuxCoreRender project with salts and bounties

marcatore
Donor
Donor
Posts: 329
Joined: Wed Jan 10, 2018 8:04 am

Re: Adaptive sampling improvements

Post by marcatore » Fri Oct 25, 2019 3:17 pm

Great. I hope you'll reach your goal!!!

User avatar
alpistinho
Developer
Developer
Posts: 168
Joined: Thu Jul 05, 2018 11:38 pm
Location: Rio de Janeiro

Re: Adaptive sampling improvements

Post by alpistinho » Fri Oct 25, 2019 11:01 pm

lacilaci wrote:
Fri Oct 25, 2019 7:50 am
unless there's visible sky... what?
I am having a hard time reproducing that. Everytime I put any visible sky, it works as intended and it gets very few samples.
Would you be able to provide a scene that shows the issue?
Support LuxCoreRender project with salts and bounties

User avatar
lacilaci
Donor
Donor
Posts: 1637
Joined: Fri May 04, 2018 5:16 am

Re: Adaptive sampling improvements

Post by lacilaci » Sat Oct 26, 2019 6:40 am

alpistinho wrote:
Fri Oct 25, 2019 11:01 pm
lacilaci wrote:
Fri Oct 25, 2019 7:50 am
unless there's visible sky... what?
I am having a hard time reproducing that. Everytime I put any visible sky, it works as intended and it gets very few samples.
Would you be able to provide a scene that shows the issue?
I'm trying to create a small example scene, but there it works as intended... super weird.
I'm trying to figure out what makes this happen

User avatar
lacilaci
Donor
Donor
Posts: 1637
Joined: Fri May 04, 2018 5:16 am

Re: Adaptive sampling improvements

Post by lacilaci » Sat Oct 26, 2019 6:51 am

Ok, so what happens is that when I have camera outside the interior then sky gets very little to no sampling and stuff works as it should.
outside.jpg
But when I put camera inside and at the same time I see the outside parts/sky then sampling pretty much just goes for the sky
inside.jpg
Btw, there is no glass it's just an opening so I have no idea why this happens

User avatar
alpistinho
Developer
Developer
Posts: 168
Joined: Thu Jul 05, 2018 11:38 pm
Location: Rio de Janeiro

Re: Adaptive sampling improvements

Post by alpistinho » Sat Oct 26, 2019 6:53 am

Very weird.

Does it happen if it is a simple box with a hole?
Happens with both sky and hdri?
Support LuxCoreRender project with salts and bounties

User avatar
lacilaci
Donor
Donor
Posts: 1637
Joined: Fri May 04, 2018 5:16 am

Re: Adaptive sampling improvements

Post by lacilaci » Sat Oct 26, 2019 9:52 am

alpistinho wrote:
Sat Oct 26, 2019 6:53 am
Very weird.

Does it happen if it is a simple box with a hole?
Happens with both sky and hdri?
Sorry I'm not at pc anymore. Will check on monday few options. But aside this issue it seem to work really good now.

User avatar
lacilaci
Donor
Donor
Posts: 1637
Joined: Fri May 04, 2018 5:16 am

Re: Adaptive sampling improvements

Post by lacilaci » Wed Oct 30, 2019 6:33 am

hm, so in a simple, box and sky scenario this doesn't happen... I'm still trying to find out what is going on.
01.jpg
that weird pattern comes from env.cache (I really don't like env cache)

User avatar
alpistinho
Developer
Developer
Posts: 168
Joined: Thu Jul 05, 2018 11:38 pm
Location: Rio de Janeiro

Re: Adaptive sampling improvements

Post by alpistinho » Wed Oct 30, 2019 6:46 am

lacilaci wrote:
Wed Oct 30, 2019 6:33 am
hm, so in a simple, box and sky scenario this doesn't happen... I'm still trying to find out what is going on.

01.jpg

that weird pattern comes from env.cache (I really don't like env cache)
Yeah, I've tried something like that and it didn't reproduce the issue

The BlendLuxCore you're using had a bug with the denoiser enabled. It was using the denoised image to drive the sampling, maybe it has something to do with that.
I sent a PR to the official repo and it should be fixed now if you want it.
Support LuxCoreRender project with salts and bounties

User avatar
lacilaci
Donor
Donor
Posts: 1637
Joined: Fri May 04, 2018 5:16 am

Re: Adaptive sampling improvements

Post by lacilaci » Wed Oct 30, 2019 7:13 am

That denoiser bug was definitely the problem, works now
02.jpg

Post Reply