Nested groups break in Lxs import

Discussion related to the LuxCore functionality, implementations and API.
User avatar
nigec
Posts: 141
Joined: Mon Mar 11, 2019 8:50 am

Nested groups break in Lxs import

Post by nigec »

Dade fixed groups in lxs imports, however if a group has a group inside it the earlier problem returns
This is what the model should look like
Letters are single groups
Letters are single groups
nestedgroups_fixed.zip
Model with single groups
(54.25 KiB) Downloaded 169 times
If all the single letter groups are nested inside the word group:
nested_broke.jpg
nestedgroups_broken.zip
(79.89 KiB) Downloaded 180 times
As a Sketchup user I use groups, you can not model with it any other way
I thought I could just explode the main group but all it take is a single group with something inside it and it screws up

luxcorerender-v2.2alpha1-win64 which I downloaded this morning
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Nested groups break in Lxs import

Post by Dade »

I will check but it may be a problem because in LuxCore you can not have instances of instances (by design) so I will have to flat the groups hierarchy at some point.
Support LuxCoreRender project with salts and bounties
User avatar
nigec
Posts: 141
Joined: Mon Mar 11, 2019 8:50 am

Re: Nested groups break in Lxs import

Post by nigec »

It would be great if you could..
Exploding the parent group works, but scenes like below take some doing lol.. I'm also getting to grips with a render view :)
Attachments
luxcore.jpg
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Nested groups break in Lxs import

Post by Dade »

I added the support for nested group to the LXS parser. It should now work.
Support LuxCoreRender project with salts and bounties
User avatar
nigec
Posts: 141
Joined: Mon Mar 11, 2019 8:50 am

Re: Nested groups break in Lxs import

Post by nigec »

Awesome thank you :D
User avatar
nigec
Posts: 141
Joined: Mon Mar 11, 2019 8:50 am

Re: Nested groups break in Lxs import

Post by nigec »

Hi Dade, it works great, even with Sketchup components
One small problem is lxs emitter materials don't work, in the following example there should be a emitter material cube, but it doesn't show (but its set as null in settings) and casts no light, if I turn off sky/sun its not even a light source.
In the zip the sky is on so it will import

PS, I tried the school corridor scene that comes with Luxrender 1.6 and that also fails to load.. I know I'm being a pain but I'd imagine the first wave of plugins are likely to use old plugins for reference.. ironically my project is failing dismally importing lxs files lol
Attachments
lighttest.zip
(9.17 KiB) Downloaded 158 times
this is what you should see
this is what you should see
Last edited by nigec on Fri Mar 29, 2019 9:04 am, edited 1 time in total.
User avatar
B.Y.O.B.
Developer
Developer
Posts: 4146
Joined: Mon Dec 04, 2017 10:08 pm
Location: Germany
Contact:

Re: Nested groups break in Lxs import

Post by B.Y.O.B. »

If I remember correctly, null materials can't emit light in LuxCore.
Use a black matte material instead.
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Nested groups break in Lxs import

Post by Dade »

B.Y.O.B. wrote: Fri Mar 29, 2019 9:00 am If I remember correctly, null materials can't emit light in LuxCore.
Use a black matte material instead.
Yes, null material is invisible for all rays so it is like if the object is not there. Can you change the material of the light source or is it done by the exporter ?
Support LuxCoreRender project with salts and bounties
User avatar
nigec
Posts: 141
Joined: Mon Mar 11, 2019 8:50 am

Re: Nested groups break in Lxs import

Post by nigec »

ah right, its the exporter, but I can change it I think
User avatar
Dade
Developer
Developer
Posts: 5672
Joined: Mon Dec 04, 2017 8:36 pm
Location: Italy

Re: Nested groups break in Lxs import

Post by Dade »

nigec wrote: Fri Mar 29, 2019 9:06 am ah right, its the exporter, but I can change it I think
Nigec, it would be nice to create a new repository for the SketchUp exporter at https://github.com/LuxCoreRender with an update version. Going trough old LXS format isn't ideal but it is still better than nothing and more user could benefit from this work.
Support LuxCoreRender project with salts and bounties
Post Reply