Page 1 of 1

VDS aka portals Test

Posted: Fri Aug 03, 2018 1:47 pm
by Sharlybg
Just start to test Visibility driven Sampling aka portal without portal. normaly it is supposed to converge faster/better. But here are the result and it seem to be broken. it seem to provide fireflies while noise level didn't really improve.

VDS OFF

VDS OFF.jpg


VDS ON

VDS ON.jpg



File :

https://drive.google.com/open?id=1odKP7 ... AuJAuRlw7e

Re: VDS aka portals Test

Posted: Fri Aug 03, 2018 2:34 pm
by B.Y.O.B.
My guess: Since fireflies are almost always unresolved caustics, it could be that the engine just finds those caustic paths earlier/better with the visibility map.
Sharlybg wrote: Fri Aug 03, 2018 1:47 pm while noise level didn't really improve
The difference is much easier to see if you render with direct light only (pathdepth 1).
The version with visibilitymap has less noise (if we forget the fireflies).

Can you try to render without visibility map for a longer time?
Maybe the fireflies appear there as well if you render long enough.
(I would do it, but it's super hot in my room already)

Re: VDS aka portals Test

Posted: Fri Aug 03, 2018 2:40 pm
by Dade
VDS accelerated only direct light sampling like portals, your scene is only indirect light aside for a triangle.

Re: VDS aka portals Test

Posted: Fri Aug 03, 2018 2:53 pm
by Sharlybg
My guess: Since fireflies are almost always unresolved caustics, it could be that the engine just finds those caustic paths earlier/better with the visibility map.
Not sure it is the case : this scene is design to especially help portal to shine. In other renderer the defference tend to be really noticeable even with global illumination.
this is a cycles test : https://plus.google.com/115529142611084 ... vG6i475vF3
White-Room-JHardy_portal-comparison2.jpg

here is a test on CPU for 45 sc.

VDS OFF

VDS OFF.jpg


VDS ON
VDS ON.jpg

Re: VDS aka portals Test

Posted: Fri Aug 03, 2018 3:04 pm
by Sharlybg
More test .
There not so much defferent between them :

file : https://drive.google.com/open?id=1nDp67 ... LkIkwj4Z-k

VDS OFF
VDS OFF.jpg
VDS i OFF.jpg
VDS ON

VDS ON.jpg
VDS i ON.jpg

Re: VDS aka portals Test

Posted: Fri Aug 03, 2018 10:28 pm
by sarmath
Hello. I've changed your scene a bit to have some direct light as Dade said to get that future to work properly.
And it definitly works.
Both images rendered to 1000 samples pathocl on gpu.

Re: VDS aka portals Test

Posted: Sat Aug 04, 2018 8:33 am
by Sharlybg
Dade wrote: Fri Aug 03, 2018 2:40 pm VDS accelerated only direct light sampling like portals, your scene is only indirect light aside for a triangle.
Ooh my bad didn't saw your answer until today :oops:
I'm glad it work. Thank you. I was in total panic mode.
sarmath wrote: Fri Aug 03, 2018 10:28 pm Hello. I've changed your scene a bit to have some direct light as Dade said to get that future to work properly.
And it definitly works.
Both images rendered to 1000 samples pathocl on gpu.
Super sarmath. Please could you try with a tiny window.

Re: VDS aka portals Test

Posted: Sat Aug 04, 2018 1:45 pm
by sarmath
Sharlybg wrote: Sat Aug 04, 2018 8:33 am
Dade wrote: Fri Aug 03, 2018 2:40 pm VDS accelerated only direct light sampling like portals, your scene is only indirect light aside for a triangle.
Ooh my bad didn't saw your answer until today :oops:
I'm glad it work. Thank you. I was in total panic mode.
sarmath wrote: Fri Aug 03, 2018 10:28 pm Hello. I've changed your scene a bit to have some direct light as Dade said to get that future to work properly.
And it definitly works.
Both images rendered to 1000 samples pathocl on gpu.
Super sarmath. Please could you try with a tiny window.
Here you have some test with small window...this time 2000 samples...

Re: VDS aka portals Test

Posted: Sat Aug 04, 2018 2:06 pm
by Sharlybg
Here you have some test with small window...this time 2000 samples...
Thanks you mate. now that i'm at home i decied to do test also and it work great as you said. animated gif :


VDS test.gif


file:
https://drive.google.com/open?id=1a_4Tl ... Egx9odYqXp

Re: VDS aka portals Test

Posted: Sat Aug 04, 2018 2:20 pm
by sarmath
....and some bidir+metropolis again 2000 samples (uh so slow...looks like bidir+metro is very inefficient in this scenario?) :?: :?: :?: