I have exposed the setting.
https://github.com/LuxCoreRender/BlendL ... 1906d8f090
big mirrors and fireflies
Forum rules
Please upload a testscene that allows developers to reproduce the problem, and attach some images.
Please upload a testscene that allows developers to reproduce the problem, and attach some images.
Re: big mirrors and fireflies
You can also just use variance clamping and ignore the problem. A value of "1" fix everything here too.
Re: big mirrors and fireflies
Actually the OIDN did just a good job to fix that fireflies but I don't really like the denoised images... I found always too clean and fake...I dont' know what it is but I prefer a good clean render straight from the renderer than a denoised one (and I'm speaking in general).
Obviously if there is no other solution, it helps... but I dislike to rely just on a denoiser to have a good image.
I prefer to consider the denoiser as emergency tool. I know..probably it's just me.
Obviously if there is no other solution, it helps... but I dislike to rely just on a denoiser to have a good image.
I prefer to consider the denoiser as emergency tool. I know..probably it's just me.
Re: big mirrors and fireflies
"Use the force (aka variance clamping) Luke"marcatore wrote: ↑Wed Jul 31, 2019 1:47 pm Actually the OIDN did just a good job to fix that fireflies but I don't really like the denoised images... I found always too clean and fake...I dont' know what it is but I prefer a good clean render straight from the renderer than a denoised one (and I'm speaking in general).
Obviously if there is no other solution, it helps... but I dislike to rely just on a denoiser to have a good image.
I prefer to consider the denoiser as emergency tool. I know..probably it's just me.
Re: big mirrors and fireflies
Sorry for my ignorance..but "variance clamping" is it available in LuxCore... I'm quite sure I'm near a facepalm
Re: big mirrors and fireflies
Tried last BlendLuxCore and last LuxCore build.
I've this error during the compilation
Using the last build ( & the last Blend addon), about the message "Scene contains a lot of light sources...." if I've set disabled for the emission material of the light fixtures, should I continue to see it or not if I disable the emission material from the DLS ?
I've this error during the compilation
Code: Select all
[LuxCore][720.537] [PathOCLBaseRenderThread::0] Compiling kernels
[LuxCore][720.990] [PathOCLBaseRenderThread::0] PathOCL kernel compilation error
ERROR clBuildProgram[CL_BUILD_PROGRAM_FAILURE]:
<kernel>:19958:10: error: unexpected type name 'Spectrum': expected expression
return Spectrum();
^
Traceback (most recent call last):
File "C:\Users\XXXXXXXXXXX\AppData\Roaming\Blender Foundation\Blender\2.
79\scripts\addons\BlendLuxCore\engine\__init__.py", line 85, in render_final
final.render(self, scene)
File "C:\Users\XXXXXXXXXXX\AppData\Roaming\Blender Foundation\Blender\2.
79\scripts\addons\BlendLuxCore\engine\final.py", line 40, in render
_render_layer(engine, scene, render_slot_stats)
File "C:\Users\XXXXXXXXXXX\AppData\Roaming\Blender Foundation\Blender\2.
79\scripts\addons\BlendLuxCore\engine\final.py", line 63, in _render_layer
engine.session.Start()
RuntimeError: PathOCLBase kernel compilation error
ERROR: PathOCLBase kernel compilation error
Error: PathOCLBase kernel compilation error
Using the last build ( & the last Blend addon), about the message "Scene contains a lot of light sources...." if I've set disabled for the emission material of the light fixtures, should I continue to see it or not if I disable the emission material from the DLS ?
Re: big mirrors and fireflies
It's just called "clamping" in BlendLuxCore, it's in the render settings below engine, sampler etc.
I think LuxCore still counts them as light sources and I get the number of light sources via scene.GetLightCount(), so the message will probably still appear.marcatore wrote: ↑Wed Jul 31, 2019 2:13 pm Using the last build ( & the last Blend addon), about the message "Scene contains a lot of light sources...." if I've set disabled for the emission material of the light fixtures, should I continue to see it or not if I disable the emission material from the DLS ?
Would be nice if there were to functions, one for the number of lights with DLS enabled and one for the number of lights without DLS.
Re: big mirrors and fireflies
Ok... now it's more clear But I'm quite sure I'm not a Jedi... But I'll try
Yes, I think could be fine cause it's better to autodebug a scene in that way.B.Y.O.B. wrote: ↑Wed Jul 31, 2019 2:45 pm I think LuxCore still counts them as light sources and I get the number of light sources via scene.GetLightCount(), so the message will probably still appear.
Would be nice if there were to functions, one for the number of lights with DLS enabled and one for the number of lights without DLS.
Re: big mirrors and fireflies
It has already been done.