One word of caution though if anyone wants to implement it in LuxCore. You cannot reuse or copy parts of the source code.happyboy wrote: ↑Tue Aug 13, 2019 2:02 amHaving the author's implementation based on a well-known codebase (Mitsuba) is great, and I'm really looking forward to see it implemented in LuxCoreDade wrote: ↑Sun Aug 11, 2019 10:54 amThis is, hand down, the best stuff out of SIGGRAPH 2019: "Path Guiding in Production" (https://jo.dreggn.org/path-tracing-in-p ... index.html)
The original implementation from Thomas Müller for Mitsuba and Mitsuba itself are licensed under GPLv3 while LuxCore is Apache v2.0 licensed.
I quote from the Mistuba homepage:
Remark: Being a "viral" license, the GPL automatically applies to all derivative work. Amongst other things, this means that without express permission, Mitsuba's source code is off-limits to those who develop rendering software not distributed under a compatible license.
Apache states: "GPLv3 software cannot be included in Apache projects. The licenses are incompatible".
We had these discussions in appleseed and our implementation (a running GSoC project) does not reuse Mitsuba code but is a unique implementation of the algorithms from the research papers.