Search found 132 matches

by alpistinho
Fri Apr 12, 2019 10:46 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

Thanks for this! I will have a closer look when I am at the computer. I am looking for related papers and will list here the ones I find promising: https://ieeexplore.ieee.org/document/5636310 https://onlinelibrary.wiley.com/doi/full/10.1111/cgf.12592 https://cseweb.ucsd.edu/~ravir/Overbeck2009AWR.p...
by alpistinho
Fri Apr 12, 2019 12:25 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

provisory wrote:
Thu Apr 11, 2019 5:37 pm
So, I've first seen the issue with this scene (100 samples in both case, warmup and test step is 5 with adaptivity):
adaptivity-test1.png
Would it be possible for you to share this scene? I am helpless with modelling things
by alpistinho
Fri Apr 12, 2019 12:24 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

In the posted example picture , the bright lamp appears noise-free to me in both renders. However, the wall is clearly more noisy in the render with adaptive sampling. In general, I agree that a noise metric should be based on the human vision system, but the metric that is currently used does not ...
by alpistinho
Fri Apr 12, 2019 11:41 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

Hi, I hope to finish the discussed changes this weekend. @Dade, can you give me a wiki account so I can update the SDL page when I change it? @Provisory, As Dade said, the metric drives the sampling to the brighter regions due to the mentioned psychovisual considerations. Do you think this is inappr...
by alpistinho
Thu Apr 11, 2019 4:00 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

provisory wrote:
Thu Apr 11, 2019 3:53 pm
It looks like brighter parts get much more samples.
I'm not in front of PC right now. Do you need an example scene?
If you have a scene that you believe the sampling is suboptimal, please share
by alpistinho
Thu Apr 11, 2019 2:30 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

provisory wrote:
Thu Apr 11, 2019 1:27 pm
Does the daily build contain the new adaptive sampling, and does it work with bidir?
Yes and yes. Please report any issues you find! ;)
by alpistinho
Thu Apr 11, 2019 1:02 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

Dade wrote:
Wed Apr 10, 2019 6:35 pm
#1 Convergence AOV with values between 0.0 and 1.0, optional stop the rendering when all values are under the halt threshold. Somewhat the old Convergence AOV.
Do you want me to normalize this or should I use the same code as before?
by alpistinho
Thu Apr 11, 2019 1:01 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

I have wrote the changes to create the new NOISE AOV, and the necessary changes on the convergence test code. I have broken LuxCoreUI and haven't been able to fix yet. I am getting: RUNTIME ERROR: Unknown FilmChannelType in Film::GetChannelCount(): 1073741824 I will try to fix it and do the suggeste...
by alpistinho
Wed Apr 10, 2019 6:31 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

As far as I remember, they are not more coupled with the new implementation. The sampling is now always proportional to the error, no matter of the halt threshold. BTW, we could try to make it not linearly proportional but quadratic: to cut the noise in half you need 4 times the samples. Currently ...
by alpistinho
Wed Apr 10, 2019 4:33 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 7184

Re: Adaptive sampling improvements

Hi, @Alpistinho: the new content of Convergence AOV ... it is not the convergence status anymore: it is more a "Relative error" AOV. The old Convergence AOV was converging to 0.0 as the rendering was going on, now instead it is pretty much constant because it is normalized between between min./max. ...