Search found 132 matches

by alpistinho
Tue Apr 16, 2019 12:23 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

As I suspected, there is something wrong. This behavior is not present on the RANDOM sampler and simply enabling the adaptiveness does not increase the noise. The adaptive Sobol sampler is worse than Random. I was suspecting that somehow the pass variable was not being incremented correctly, but it ...
by alpistinho
Mon Apr 15, 2019 11:22 pm
Forum: Development
Topic: MaxLuxCore - 3ds Max Integration for LuxCore
Replies: 51
Views: 3822

Re: MaxLuxCore - 3ds Max Integration for LuxCore

Nice progress TAO!
by alpistinho
Sun Apr 14, 2019 6:01 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

From what I know, with Bidir only about half the samples can be adaptive (the ones shot from the camera). Yes, I know. I just don't know what other effects this causes on the rendering. I've checked the SAMPLECOUNT and even with like 60% more samples the adaptive is still noisier. Something is wrong
by alpistinho
Sun Apr 14, 2019 4:34 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

It doesn't matter, that it uses bidir, does it? The adaptiveness does work with bidir, I don't really know if there may be some other interaction with MIS or something like that. @Dade may be able to offer some input. If you have a scene that shows this using Path, it would be nice. This one has to...
by alpistinho
Sun Apr 14, 2019 3:46 pm
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

I've uploaded the - slightly modified - scene. (I've removed the textures, hdri, and other unrelated things.) Thanks for the scene. I've tested it and the first problem I am seeing is that although the adaptive has more samples in some regions, those are still noisier than the the non-adaptive vers...
by alpistinho
Sun Apr 14, 2019 11:37 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

You need to split the "convergence" and "adaptive sampling input" process: 1) convergence test must be done at the end of the image pipeline; 2) adaptive sampling input can be the result of whatever you want; The first step of this split was to have 2 separate AOVs (i.e. Convergence + Noise AOVs) n...
by alpistinho
Sun Apr 14, 2019 1:12 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

Another thing to consider implementing is that the paper proposes using a second framebuffer where just the every second sample is stored and using these two buffers to calculate the metric. This may work better and maybe it is easier to use since the step parameter would become less critical. Would...
by alpistinho
Sun Apr 14, 2019 12:43 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

It is intended and the result of this line of code: https://github.com/LuxCoreRender/LuxCore/blob/1d15797aafff9f7c25e8d41195bb238ae092c9ae/src/slg/film/convtest/filmconvtest.cpp#L121 const float imgSum = imgR + imgG + imgB; const float diff = (imgSum != 0.f) ? ((dr + dg + db) / sqrt(imgR + imgG + i...
by alpistinho
Sun Apr 14, 2019 12:28 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

Hi, I think the issue here is that we're using the pixels from the image after it has been tonemapped. const float *img = film->channel_IMAGEPIPELINEs[0]->GetPixels(); Am I correct in that assumption? I've noticed that changing the tonemapper gain drastically changes the NOISE channel computed. The ...
by alpistinho
Sat Apr 13, 2019 2:06 am
Forum: Development
Topic: Adaptive sampling improvements
Replies: 121
Views: 6928

Re: Adaptive sampling improvements

About the actual development: I've finished fixing LuxCoreUI, so there is now an extra AOV called NOISE and the CONVERGENCE is like it was before. I will work now on the new parameters, so to improve the ergonomics and possibilities, and will have a look about the metric after that. About the metric...